Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[angle] crash on macos #29622

Closed
xiaozhuai opened this issue Feb 13, 2023 · 8 comments · Fixed by #31163
Closed

[angle] crash on macos #29622

xiaozhuai opened this issue Feb 13, 2023 · 8 comments · Fixed by #31163
Assignees
@jimwang118
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@xiaozhuai
Copy link
Contributor

xiaozhuai commented Feb 13, 2023 •
edited
Loading

Describe the bug
angle+glfw crash on macos after #27444

Here is a demo project vcpkg_demo

image

Also, theres is a warning when running on macos

objc[91749]: Class WebSwapCGLLayer is implemented in both /System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks/libANGLE-shared.dylib (0x7ffb5026aec8) and /Users/xiaozhuai/work/vcpkg_demo/cmake-build-debug/opengles_angle/vcpkg_demo_opengles_angle (0x10909dbd8). One of the two will be used. Which one is undefined.

Environment

  • OS: MacOS 12.6.3
  • Compiler: Apple clang version 14.0.0 (clang-1400.0.29.202)
@jimwang118 jimwang118 added the category:port-bug The issue is with a library, which is something the port should already support label Feb 13, 2023
@xiaozhuai
Copy link
Contributor Author

Hi @jimwang118 , any progress on this? I investigated, but found nothing.

@jimwang118
Copy link
Contributor

Hi @jimwang118 , any progress on this? I investigated, but found nothing.

Can you tell me the specific detailed operation?

@xiaozhuai
Copy link
Contributor Author

@jimwang118
Check this repo vcpkg_demo
Comment out other demos. You will need only this add_subdirectory(opengles_angle)
And then build and run on macos.

@jimwang118
Copy link
Contributor

Ok, I reproduced the problem locally and I'm fixing up this.

@jimwang118
Copy link
Contributor

Thanks for posting this issue. This issue has been fixed. So I am closing this issue for now. 

@xiaozhuai
Copy link
Contributor Author

@jimwang118 Thanks for the fixing. Could you please give a link to the fixed pr, I can't find it.

@xiaozhuai xiaozhuai mentioned this issue Mar 15, 2023
Closed
@xiaozhuai
Copy link
Contributor Author

xiaozhuai commented Mar 15, 2023 •
edited
Loading

@jimwang118 I don't think this issue has been fixed. I've double checkd and there is no pr link to this issue. Please re-open this.

@FrankXie05 FrankXie05 reopened this Mar 15, 2023
@FrankXie05 FrankXie05 mentioned this issue Mar 15, 2023
Open
xiaozhuai added a commit to xiaozhuai/vcpkg that referenced this issue Apr 28, 2023
@xiaozhuai
[angle] Fix crash on macos microsoft#29622
0938830
@xiaozhuai xiaozhuai mentioned this issue Apr 28, 2023
Merged
7 tasks
@xiaozhuai
Copy link
Contributor Author

After an in-depth investigation, I finally found the problem. And this will be fixed by #31163

JavierMatosD pushed a commit that referenced this issue May 2, 2023
@xiaozhuai
[angle] Fix crash on macos #29622 (#31163)
d5644a4 
* [angle] Fix crash on macos #29622

* update version database
@daschuer daschuer mentioned this issue Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimwang118 jimwang118

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[angle] Fix crash on macos #29622 xiaozhuai/vcpkg
3 participants
@xiaozhuai @FrankXie05 @jimwang118