-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lapack-reference] enable fortran if possible for find blas #14765
[lapack-reference] enable fortran if possible for find blas #14765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the port version. See documentation.
openmvg:x64-osx:
sophus:x64-osx:
|
Huh. I will try to find some OSX to check. But now it looks like a problem with building |
I also don't understand why you are enabling Fortan. The |
@Neumann-A thank you for your answer. |
Even though LAPACK is a Fortran library it can be called from c and linked against without having a Fortran compiler available. So I assume the problem here is a linkage issue in reality? What was the actual error message? |
Yes. You are right. Problem with linkage. |
normally this should be handled by this: vcpkg/ports/lapack-reference/FindLAPACK.cmake Lines 463 to 475 in 6c9cda1
|
Yes, should. but cmake can't find gfortran. Hm. |
Describe the pull request
If Fortran language not enabled FindLAPACK fails on default configuration.
What does your PR fix? Fixes #
FindLAPACK.cmake
Which triplets are supported/not supported? Have you updated the CI baseline?
as previous, no
Does your PR follow the maintainer guide?
yes