[intel-mkl] Support Linux #15233

JackBoosY · 2020-12-21T07:09:28Z

Support search in linux.

JackBoosY · 2020-12-21T07:13:22Z

Prepare for #15208.

JackBoosY · 2020-12-21T07:36:10Z

@BillyONeal To delete the linux failure entry of the port in the baseline, we must install Intel-mkl on the linux pipeline machines.

BillyONeal · 2020-12-21T19:50:36Z

The links to intel-mkl we currently install for Windows aren't publicly accessible; someone who cared provided them for our scripts but I don't know how to get to an associated download page. As such, ci.baseline.txt seems appropriate for now: there's no reason it couldn't work, but we don't have great means to test it. Someone who cares would need to give us instructions we could add to provision-image.sh to deploy it.

JackBoosY · 2020-12-22T07:30:56Z

@BillyONeal We should add several commands:

wget https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS-2019.PUB
apt-key add GPG-PUB-KEY-INTEL-SW-PRODUCTS-2019.PUB
rm GPG-PUB-KEY-INTEL-SW-PRODUCTS-2019.PUB
sudo sh -c 'echo deb https://apt.repos.intel.com/mkl all main > /etc/apt/sources.list.d/intel-mkl.list'
sudo apt-get update
sudo apt-get install intel-mkl-2020.0-000

Neumann-A · 2021-01-11T08:42:54Z

currently #15204 is not fixed by this PR.

JackBoosY · 2021-01-11T09:39:27Z

@Neumann-A That's why I changed this PR to draft.

Neumann-A · 2021-01-11T09:49:20Z

portfile.txt
I used the above portfile. You can probably simply merge the Linux/Windows Paths by simply adding the linux path to find_path

…jack/15204

JackBoosY · 2021-01-12T05:52:40Z

@Neumann-A
967f60a
Is that what you mean?

Neumann-A · 2021-01-13T20:42:26Z

@JackBoosY No with the current patchset it still wouldn't be found.

JackBoosY · 2021-02-07T02:36:12Z

Close this PR temporary.

AND2797 · 2021-05-04T00:46:35Z

Is there a way to locally test changes?

BillyONeal · 2021-05-04T20:42:01Z

Is there a way to locally test changes?

You can pull Jack's branch

BillyONeal · 2021-06-01T21:06:36Z

Dropping vm update tag since there are no vm update changes in the pr

JackBoosY · 2021-06-07T02:46:10Z

Close this PR temporary.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 88b1071e39f13b632644d9d953738d345a4ac055 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index ae7869dc..416b2a00 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3046,7 +3046,7 @@
     },
     "intel-mkl": {
       "baseline": "2020.0.0",
-      "port-version": 2
+      "port-version": 3
     },
     "intelrdfpmathlib": {
       "baseline": "20U2",
diff --git a/versions/i-/intel-mkl.json b/versions/i-/intel-mkl.json
index 1c5ffb0e..c900a741 100644
--- a/versions/i-/intel-mkl.json
+++ b/versions/i-/intel-mkl.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "f7ebdf18103f6d02eb173fc64ddef9cd3d80346f",
+      "version": "2020.0.0",
+      "port-version": 3
+    },
     {
       "git-tree": "f2d5b828df130d8b1106aa0c076eb9cb79e50ea9",
       "version": "2020.0.0",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/intel-mkl/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 88b1071e39f13b632644d9d953738d345a4ac055 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 1d942429..31cb1d21 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3058,7 +3058,7 @@
     },
     "intel-mkl": {
       "baseline": "2020.0.0",
-      "port-version": 2
+      "port-version": 3
     },
     "intelrdfpmathlib": {
       "baseline": "20U2",
diff --git a/versions/i-/intel-mkl.json b/versions/i-/intel-mkl.json
index 1c5ffb0e..800b9521 100644
--- a/versions/i-/intel-mkl.json
+++ b/versions/i-/intel-mkl.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "497999f5fb011aed88b6e01ac43eb11a22ebb7aa",
+      "version": "2020.0.0",
+      "port-version": 3
+    },
     {
       "git-tree": "f2d5b828df130d8b1106aa0c076eb9cb79e50ea9",
       "version": "2020.0.0",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/intel-mkl/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 88b1071e39f13b632644d9d953738d345a4ac055 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 1d942429..31cb1d21 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3058,7 +3058,7 @@
     },
     "intel-mkl": {
       "baseline": "2020.0.0",
-      "port-version": 2
+      "port-version": 3
     },
     "intelrdfpmathlib": {
       "baseline": "20U2",
diff --git a/versions/i-/intel-mkl.json b/versions/i-/intel-mkl.json
index 1c5ffb0e..18552227 100644
--- a/versions/i-/intel-mkl.json
+++ b/versions/i-/intel-mkl.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "002881c8b3e9d7a6b4feca6568dfaadfe49e52a7",
+      "version": "2020.0.0",
+      "port-version": 3
+    },
     {
       "git-tree": "f2d5b828df130d8b1106aa0c076eb9cb79e50ea9",
       "version": "2020.0.0",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/intel-mkl/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 88b1071e39f13b632644d9d953738d345a4ac055 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 1d942429..31cb1d21 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3058,7 +3058,7 @@
     },
     "intel-mkl": {
       "baseline": "2020.0.0",
-      "port-version": 2
+      "port-version": 3
     },
     "intelrdfpmathlib": {
       "baseline": "20U2",
diff --git a/versions/i-/intel-mkl.json b/versions/i-/intel-mkl.json
index 1c5ffb0e..18552227 100644
--- a/versions/i-/intel-mkl.json
+++ b/versions/i-/intel-mkl.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "002881c8b3e9d7a6b4feca6568dfaadfe49e52a7",
+      "version": "2020.0.0",
+      "port-version": 3
+    },
     {
       "git-tree": "f2d5b828df130d8b1106aa0c076eb9cb79e50ea9",
       "version": "2020.0.0",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/intel-mkl/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 88b1071e39f13b632644d9d953738d345a4ac055 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 1d942429..31cb1d21 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3058,7 +3058,7 @@
     },
     "intel-mkl": {
       "baseline": "2020.0.0",
-      "port-version": 2
+      "port-version": 3
     },
     "intelrdfpmathlib": {
       "baseline": "20U2",
diff --git a/versions/i-/intel-mkl.json b/versions/i-/intel-mkl.json
index 1c5ffb0e..18552227 100644
--- a/versions/i-/intel-mkl.json
+++ b/versions/i-/intel-mkl.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "002881c8b3e9d7a6b4feca6568dfaadfe49e52a7",
+      "version": "2020.0.0",
+      "port-version": 3
+    },
     {
       "git-tree": "f2d5b828df130d8b1106aa0c076eb9cb79e50ea9",
       "version": "2020.0.0",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/intel-mkl/vcpkg.json

Valid values for the license field can be found in the documentation

…jack/15204

JackBoosY · 2022-09-02T02:04:45Z

intel-mkl is not avaliable on brew, so I can only add Linux support here.

BillyONeal · 2022-09-22T19:44:41Z

Note that this is likely to cause changes in which implementation if Lapack is selected because CMake's built in FindLAPACK seems to prefer MKL over what we currently are trying to use, OpenBLAS. See https://cmake.org/cmake/help/latest/module/FindLAPACK.html / https://cmake.org/cmake/help/latest/module/FindBLAS.html#blas-lapack-vendors

JackBoosY · 2022-09-23T02:44:11Z

Note that this is likely to cause changes in which implementation if Lapack is selected because CMake's built in FindLAPACK seems to prefer MKL over what we currently are trying to use, OpenBLAS. See https://cmake.org/cmake/help/latest/module/FindLAPACK.html / https://cmake.org/cmake/help/latest/module/FindBLAS.html#blas-lapack-vendors

So should we fix lapack issue first? #21479

* Revert Linux to Ubuntu 20.04. * Cherry-pick intel-mkl from #15233 * Update pwsh to 7.2.6. * Temporarily remove ci.baseline.txt skips for ICEs. * Fix ICU version for Ubuntu version change. * Update pools. * Merge apt installs and fix WSL CUDA bindings. * Fix WSL detection. * Remove WSL specific nvidia because it misses nccl and cudnn. * Add python-yaml for duktape. * [shogun] Force use of OpenBLAS as the Lapack implementation. Shogun declares a dependency on blas, which we have set to openblas. Installing Intel MKL on the VMs caused build of Shogun to fail because it tried to use MKL and that build is broken. * Put colmap, graphicsmagick, and mfl skips back, as they are clearly not fixed. * PASSING, REMOVE FROM FAIL LIST: jemalloc:x64-osx (/Users/vagrant/Data/work/2/s/scripts/azure-pipelines/../ci.baseline.txt). * Update pool. * Revert the intel-mkl changes until the BLAS/LAPACK vendoring problem is fixed. * Update pool. * Explicitly add bison, needed by gettext. * Update pools

JackBoosY · 2022-10-08T09:57:54Z

Okay, according to the feedback in #15204, this PR is just waiting for #21479 merge.

JackBoosY · 2023-02-07T06:04:14Z

In favor of #29437

[intel-mkl] Support Linux

f99db2d

JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Dec 21, 2020

JackBoosY assigned PhoebeHui Dec 21, 2020

JackBoosY requested a review from PhoebeHui December 21, 2020 07:36

BillyONeal added the depends:vm-update PR contains changes to the VM provisioning scripts label Dec 23, 2020

JackBoosY marked this pull request as draft January 11, 2021 05:59

JackBoosY mentioned this pull request Jan 11, 2021

[intel-mkl] not detecting intel mkl from Intel oneAPI #15548

Closed

JackBoosY linked an issue Jan 11, 2021 that may be closed by this pull request

[intel-mkl] not detecting intel mkl from Intel oneAPI #15548

Closed

JackBoosY added 2 commits January 11, 2021 21:49

Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…

00cf89d

…jack/15204

[intel-mkl] Support search from ENVs

967f60a

JackBoosY closed this Feb 7, 2021

JackBoosY reopened this May 3, 2021

JackBoosY mentioned this pull request May 3, 2021

[intel-mkl:x64-linux] build failure #15204

Closed

BillyONeal removed the depends:vm-update PR contains changes to the VM provisioning scripts label Jun 1, 2021

JackBoosY closed this Jun 7, 2021

github-actions bot requested changes Aug 24, 2022

View reviewed changes

fix in linux

ac197bb

github-actions bot requested changes Sep 1, 2022

View reviewed changes

Add subpath include for non-apt

6b0d245

github-actions bot requested changes Sep 2, 2022

View reviewed changes

JackBoosY added 2 commits September 1, 2022 17:03

Add apt package intel-mkl

deedd7f

update baseline

ed75214

github-actions bot requested changes Sep 2, 2022

View reviewed changes

JackBoosY added 3 commits September 1, 2022 18:54

Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…

8ff2bc6

…jack/15204

Add wrapper

1d5d549

version

2aa1218

JackBoosY marked this pull request as ready for review September 2, 2022 01:55

github-actions bot previously approved these changes Sep 2, 2022

View reviewed changes

JackBoosY added the depends:vm-update PR contains changes to the VM provisioning scripts label Sep 2, 2022

BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Sep 20, 2022

Cherry-pick intel-mkl from microsoft#15233

2285887

BillyONeal mentioned this pull request Sep 22, 2022

VM Update September 2022 #26895

Merged

Merge branch 'master' into dev/jack/15204

9221a36

JackBoosY dismissed github-actions[bot]’s stale review via 9221a36 October 8, 2022 09:36

github-actions bot approved these changes Oct 8, 2022

View reviewed changes

JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Oct 8, 2022

LilyWangLL assigned FrankXie05 Dec 6, 2022

JackBoosY mentioned this pull request Feb 6, 2023

[intel-mkl] install mkl instead of requesting the user to install it #29437

Merged

JackBoosY closed this Feb 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[intel-mkl] Support Linux #15233

[intel-mkl] Support Linux #15233

JackBoosY commented Dec 21, 2020

JackBoosY commented Dec 21, 2020

JackBoosY commented Dec 21, 2020

BillyONeal commented Dec 21, 2020

JackBoosY commented Dec 22, 2020

Neumann-A commented Jan 11, 2021

JackBoosY commented Jan 11, 2021

Neumann-A commented Jan 11, 2021

JackBoosY commented Jan 12, 2021

Neumann-A commented Jan 13, 2021

JackBoosY commented Feb 7, 2021

AND2797 commented May 4, 2021

BillyONeal commented May 4, 2021

BillyONeal commented Jun 1, 2021

JackBoosY commented Jun 7, 2021

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

JackBoosY commented Sep 2, 2022

BillyONeal commented Sep 22, 2022

JackBoosY commented Sep 23, 2022

JackBoosY commented Oct 8, 2022

JackBoosY commented Feb 7, 2023

[intel-mkl] Support Linux #15233

[intel-mkl] Support Linux #15233

Conversation

JackBoosY commented Dec 21, 2020

JackBoosY commented Dec 21, 2020

JackBoosY commented Dec 21, 2020

BillyONeal commented Dec 21, 2020

JackBoosY commented Dec 22, 2020

Neumann-A commented Jan 11, 2021

JackBoosY commented Jan 11, 2021

Neumann-A commented Jan 11, 2021

JackBoosY commented Jan 12, 2021

Neumann-A commented Jan 13, 2021

JackBoosY commented Feb 7, 2021

AND2797 commented May 4, 2021

BillyONeal commented May 4, 2021

BillyONeal commented Jun 1, 2021

JackBoosY commented Jun 7, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JackBoosY commented Sep 2, 2022

BillyONeal commented Sep 22, 2022

JackBoosY commented Sep 23, 2022

JackBoosY commented Oct 8, 2022

JackBoosY commented Feb 7, 2023