-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fltk] Fix link to system libs #17094
Conversation
@MoAlyousef Can you please test this PR? Thanks. |
@JackBoosY Odd. This worked without any errors, but nothing launched when the compiled executable was run. On the otherhand, my original test-case worked with this slight edit to my if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
find_library(COCOA_LIBRARY Cocoa ONLY)
target_link_libraries(${PROJECT_NAME} PRIVATE ${COCOA_LIBRARY})
endif() EDIT: Try this fix of mine on the previous tree not the one after this PR is applied… otherwise it won't work |
I'm afraid I can't test on macos at the moment |
@SamuelMarks This modification adapts #16706. |
@JackBoosY / @vicroms : I'm happy this has merged, because it resolved the errors. But it hasn't solved the referenced issue #17053; the GUI window still isn't drawn on my screen. |
@SamuelMarks Can you please open a new issue to report this? Thanks. |
fltk forgot to export some system libraries in the cmake configuration file on Windows and OSX, fix this.
Fixes #17053.