Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fltk] Fix link to system libs #17094

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Conversation

JackBoosY
Copy link
Contributor

fltk forgot to export some system libraries in the cmake configuration file on Windows and OSX, fix this.

Fixes #17053.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Apr 5, 2021
@JackBoosY
Copy link
Contributor Author

@MoAlyousef Can you please test this PR?

Thanks.

@JackBoosY JackBoosY requested a review from NancyLi1013 April 5, 2021 06:12
@SamuelMarks
Copy link
Contributor

SamuelMarks commented Apr 5, 2021

@JackBoosY Odd. This worked without any errors, but nothing launched when the compiled executable was run. On the otherhand, my original test-case worked with this slight edit to my CMakeLists.txt:

if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
    find_library(COCOA_LIBRARY Cocoa ONLY)
    target_link_libraries(${PROJECT_NAME} PRIVATE ${COCOA_LIBRARY})
endif()

EDIT: Try this fix of mine on the previous tree not the one after this PR is applied… otherwise it won't work

@MoAlyousef
Copy link
Contributor

I'm afraid I can't test on macos at the moment

@JackBoosY
Copy link
Contributor Author

@SamuelMarks This modification adapts #16706.

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Apr 7, 2021
@vicroms vicroms merged commit 59b938e into microsoft:master Apr 9, 2021
@SamuelMarks
Copy link
Contributor

@JackBoosY / @vicroms : I'm happy this has merged, because it resolved the errors. But it hasn't solved the referenced issue #17053; the GUI window still isn't drawn on my screen.

@JackBoosY JackBoosY deleted the dev/jack/17053 branch April 11, 2021 09:17
@JackBoosY
Copy link
Contributor Author

@SamuelMarks Can you please open a new issue to report this?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fltk] Undefined symbols on macOS 11.1 (20C69)
5 participants