Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scripts-audit] z_vcpkg_get_cmake_vars #18837

Closed
wants to merge 4 commits into from
Closed

[scripts-audit] z_vcpkg_get_cmake_vars #18837

wants to merge 4 commits into from

Conversation

strega-nil-ms
Copy link
Contributor

Rename vcpkg_internal_get_cmake_vars -> z_vcpkg_get_cmake_vars, and do an audit. Also add a cache variable so we don't rerun, and remove the OPTIONS variable since it probably shouldn't be used.

@strega-nil-ms strega-nil-ms marked this pull request as draft July 6, 2021 16:35
@dg0yt
Copy link
Contributor

dg0yt commented Jul 6, 2021

remove the OPTIONS variable since it probably shouldn't be used.

OPTIONS allowed to query additional variable without changing this script. A pending use is in PR #16706.
However, I would agree that this must eventually be achieved in another way - OPTIONS requires knowledge of implementation details.

@dg0yt
Copy link
Contributor

dg0yt commented Jul 6, 2021

I wish there was a way to silence the output of this function. It causes an extra "Configuring " which is quite confusing.

@strega-nil-ms
Copy link
Contributor Author

Closing because this is the wrong account -.-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strega-nil-ms @dg0yt @strega-nil