[scripts-audit] z_vcpkg_get_cmake_vars

[strega-nil]

Rename vcpkg_internal_get_cmake_vars -> z_vcpkg_get_cmake_vars, and do an audit. Also add a cache variable so we don't rerun, and remove the OPTIONS variable since it probably shouldn't be used.

[strega-nil]

From @dg0yt:

remove the OPTIONS variable since it probably shouldn't be used.

OPTIONS allowed to query additional variable without changing this script. A pending use is in PR #16706.
However, I would agree that this must eventually be achieved in another way - OPTIONS requires knowledge of implementation details.

[strega-nil]

From @dg0yt:

I wish there was a way to silence the output of this function. It causes an extra "Configuring " which is quite confusing.

[strega-nil]

remove the OPTIONS variable since it probably shouldn't be used.

OPTIONS allowed to query additional variable without changing this script. A pending use is in PR #16706.
However, I would agree that this must eventually be achieved in another way - OPTIONS requires knowledge of implementation details.

I'd say the way to do this is to add the variables to get_cmake_vars, as opposed to adding extra options

I wish there was a way to silence the output of this function. It causes an extra "Configuring " which is quite confusing.

this is a good point.

[strega-nil-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 4990d2b9510876531eb7e73eeba09210178e804f -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/f-/ffmpeg.json b/versions/f-/ffmpeg.json
index 85acde8..ed13062 100644
--- a/versions/f-/ffmpeg.json
+++ b/versions/f-/ffmpeg.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "87ed46717cf5268cc6f4502bafabc28a01bce39c",
+      "git-tree": "337b3b6207cf0bf424472af73439176f835497e1",
       "version": "4.4",
       "port-version": 11
     },

[strega-nil-ms]

Closed for rollup