Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libass] switch the build system to meson and enable asm optimization #19513

Closed
wants to merge 2 commits into from

Conversation

Masaiki
Copy link
Contributor

@Masaiki Masaiki commented Aug 12, 2021

Describe the pull request

  • What does your PR fix?

    switch the build system to meson and enable asm optimization, meson files from Port of the build system to meson libass/libass#330, with few changes.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Aug 12, 2021
@Masaiki
Copy link
Contributor Author

Masaiki commented Aug 13, 2021

x64-windows and x86-windows failed because ass.lib was not generated.
I can't find out why...

@JackBoosY
Copy link
Contributor

[20/21] "D:\downloads\tools\python\python-3.9.6-x64\python.exe" "D:\downloads\tools\meson\meson-aeda7f249c4a5dbbecc52e44f382246a2377b5b0\meson.py" "install" "--no-rebuild"
Installing libass\ass.dll to D:/packages/libass_x64-windows/debug\bin
Traceback (most recent call last):
  File "D:\downloads\tools\meson\meson-aeda7f249c4a5dbbecc52e44f382246a2377b5b0\mesonbuild\mesonmain.py", line 134, in run
    return options.run_func(options)
  File "D:\downloads\tools\meson\meson-aeda7f249c4a5dbbecc52e44f382246a2377b5b0\mesonbuild\minstall.py", line 719, in run
    installer.do_install(datafilename)
  File "D:\downloads\tools\meson\meson-aeda7f249c4a5dbbecc52e44f382246a2377b5b0\mesonbuild\minstall.py", line 511, in do_install
    self.install_targets(d, dm, destdir, fullprefix)
  File "D:\downloads\tools\meson\meson-aeda7f249c4a5dbbecc52e44f382246a2377b5b0\mesonbuild\minstall.py", line 614, in install_targets
    raise RuntimeError(f'File {t.fname!r} could not be found')
RuntimeError: File 'libass\\ass.lib' could not be found
FAILED: meson-install 
"D:\downloads\tools\python\python-3.9.6-x64\python.exe" "D:\downloads\tools\meson\meson-aeda7f249c4a5dbbecc52e44f382246a2377b5b0\meson.py" "install" "--no-rebuild"
ninja: build stopped: subcommand failed.

@Masaiki
Copy link
Contributor Author

Masaiki commented Aug 17, 2021

add patch from ShiftMediaProject/libass@9a92b60
add .def back to export functions.
request for a review @JackBoosY , thanks

@JackBoosY
Copy link
Contributor

Depends on #19629.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 18, 2021
meson files from TypesettingTools/libass@meson-pr
@Masaiki
Copy link
Contributor Author

Masaiki commented Aug 22, 2021

Remove codes about subproject for vcpkg doesn't need it.

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 23, 2021
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the upstream not support meson now? I noticed you manually copied the meson scripts.

@Masaiki
Copy link
Contributor Author

Masaiki commented Aug 23, 2021

Does the upstream not support meson now? I noticed you manually copied the meson scripts.

meson scripts are from this pr libass/libass#330, and I do some fixes for it. upstream only support autoconf.

@JackBoosY
Copy link
Contributor

@Masaiki Okay, let's wait for libass/libass#330 merge.

@JackBoosY JackBoosY added depends:upstream-changes Waiting on a change to the upstream project and removed requires:author-response labels Aug 23, 2021
@Masaiki Masaiki closed this Sep 14, 2021
@JackBoosY
Copy link
Contributor

Why close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants