-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libass] switch the build system to meson and enable asm optimization #19513
Conversation
db2cb94
to
139a61e
Compare
x64-windows and x86-windows failed because ass.lib was not generated. |
|
1d4978c
to
8587f0a
Compare
add patch from ShiftMediaProject/libass@9a92b60 |
Depends on #19629. |
8587f0a
to
1d4978c
Compare
1d4978c
to
d51292d
Compare
meson files from TypesettingTools/libass@meson-pr
d51292d
to
db336fa
Compare
Remove codes about subproject for vcpkg doesn't need it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the upstream not support meson now? I noticed you manually copied the meson scripts.
meson scripts are from this pr libass/libass#330, and I do some fixes for it. upstream only support autoconf. |
@Masaiki Okay, let's wait for libass/libass#330 merge. |
Why close this? |
Describe the pull request
What does your PR fix?
switch the build system to meson and enable asm optimization, meson files from Port of the build system to meson libass/libass#330, with few changes.
Which triplets are supported/not supported? Have you updated the CI baseline?
all, Yes
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/