-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gettext] Remove SUBPATH
, add iconv linking info
#20090
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@dg0yt can you also remove the |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@wrobelda I have to revert the related change. The issue is that kf5i18n doesn't use the wrapped |
Thanks for the bugfix! |
What does your PR fix?
SUBPATH
argument tovcpkg_build_make
, as discussed in [scripts-audit] Make buildsystem (port) #19753 (CC @JackBoosY)Iconv_LIBRARIES
toIntl_LIBRARIES
in Intl wrapper, as discussed in [kf5package] new port #19195 (CC @wrobelda)Reverts the kf5i18n patching for the gettext -> iconv dependency which is now handled in gettext ([gettext] Remove(kf5i18n doesn't useSUBPATH
, add iconv linking info #20090 (comment)).FindIntl.cmake
.)Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Tested locally in x64-mingw-static cross build.
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes