Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg ci pipeline] suggest vcpkg_*_cmake -> vcpkg_cmake_* migration #20142

Merged

Conversation

autoantwort
Copy link
Contributor

No description provided.

@autoantwort autoantwort force-pushed the request-cmake_vcpkg-conversion branch from e4c1251 to ae77333 Compare September 14, 2021 02:53
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated funktions are used. If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},{
  "name": "vcpkg-cmake-config",
  "host": true
}```
The following files are affected: ports/kf5textwidgets/portfile.cmake
ports/utfcpp/portfile.cmake

@autoantwort autoantwort force-pushed the request-cmake_vcpkg-conversion branch from ae77333 to aa1702b Compare September 14, 2021 03:01
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used. If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/python3/portfile.cmake
  • ports/utfcpp/portfile.cmake

@autoantwort autoantwort force-pushed the request-cmake_vcpkg-conversion branch from aa1702b to f79357b Compare September 14, 2021 03:09
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions: `vcpkg_install_cmake` -> `vcpkg_cmake_install` (from port `vcpkg-cmake`) `vcpkg_build_cmake` -> `vcpkg_cmake_build` (from port `vcpkg-cmake`) `vcpkg_configure_cmake` -> `vcpkg_cmake_configure` (Please remove the option `PREFER_NINJA`) (from port `vcpkg-cmake`) `vcpkg_fixup_cmake_targets` -> `vcpkg_cmake_config_fixup` (from port `vcpkg-cmake-config`)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

@autoantwort autoantwort force-pushed the request-cmake_vcpkg-conversion branch from f79357b to f7ed06f Compare September 14, 2021 03:11
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

@autoantwort autoantwort force-pushed the request-cmake_vcpkg-conversion branch from f7ed06f to e6cafdc Compare September 14, 2021 03:15
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/utfcpp/portfile.cmake

@autoantwort autoantwort force-pushed the request-cmake_vcpkg-conversion branch from e6cafdc to e6fa54d Compare September 14, 2021 03:18
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/armadillo/portfile.cmake

@autoantwort
Copy link
Contributor Author

I have now moved the text into the Details so that the message is not so long. The PR is now ready.

@autoantwort autoantwort force-pushed the request-cmake_vcpkg-conversion branch from e6fa54d to 12e5dff Compare September 14, 2021 03:23
@PhoebeHui PhoebeHui self-assigned this Sep 14, 2021
@PhoebeHui PhoebeHui added the category:infrastructure Pertaining to the CI/Testing infrastrucutre label Sep 14, 2021
@PhoebeHui PhoebeHui changed the title ci: suggest vcpkg_*_cmake -> vcpkg_cmake_* migration [vcpkg ci pipeline] suggest vcpkg_*_cmake -> vcpkg_cmake_* migration Sep 14, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 15, 2021
@BillyONeal
Copy link
Member

funktions

It's getting funky in here! :D

@Neumann-A
Copy link
Contributor

It's getting funky in here! :D

That is just a german language party ;) (https://dict.leo.org/german-english/function)

@BillyONeal
Copy link
Member

It's getting funky in here! :D

That is just a german language party ;) (https://dict.leo.org/german-english/function)

🎉🎉🎉🎉🎉🎉🎉🎈🎈🎈🎈🎈🎈🥳🥳🥳🥳🥳🥳🎈🎈🎈🎈🎈🎉🎉🎉🎉🎉

@BillyONeal BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Sep 15, 2021
@BillyONeal
Copy link
Member

Dropping reviewed: This is good to go but I'm going to make sure other maintainers are OK with it (~11AM pacific tomorrow time)

@dg0yt
Copy link
Contributor

dg0yt commented Sep 16, 2021

This should perhaps be backed by adding the deprecated functions to https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#avoid-deprecated-helper-functions.

@BillyONeal
Copy link
Member

Thanks for your help!

@BillyONeal BillyONeal merged commit 30a3d84 into microsoft:master Sep 16, 2021
@BillyONeal
Copy link
Member

BillyONeal commented Sep 16, 2021

This should perhaps be backed by adding the deprecated functions to https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#avoid-deprecated-helper-functions.

I agree. @autoantwort I added this to my pile for today but if you get to it before me that would be great. that's done

@wrobelda
Copy link
Contributor

wrobelda commented Sep 16, 2021

I just saw this in action in #19756 and it seems to look at some older commits in the PR, because its recommendation is off?

@BillyONeal
Copy link
Member

@autoantwort Can you take a look at @wrobelda 's report?

@BillyONeal
Copy link
Member

Another example where it did the wrong thing: #20207

@autoantwort
Copy link
Contributor Author

I will look at it now

@autoantwort
Copy link
Contributor Author

Fix in #20218

BillyONeal added a commit that referenced this pull request Sep 20, 2021
…ide. (#20217)

* Document deprecated functions from #20142 in the maintainer guide.

See discussion at #20142 (comment)

* Reorder list to match natural `portfile.cmake` order, as suggested by @dg0yt
Sungeun0318 pushed a commit to Sungeun0318/-vcpkg that referenced this pull request May 15, 2024
…ide. (#20217)

* Document deprecated functions from #20142 in the maintainer guide.

See discussion at microsoft/vcpkg#20142 (comment)

* Reorder list to match natural `portfile.cmake` order, as suggested by @dg0yt
Sungeun0318 pushed a commit to Sungeun0318/-vcpkg that referenced this pull request May 15, 2024
…ide. (#20217)

* Document deprecated functions from #20142 in the maintainer guide.

See discussion at microsoft/vcpkg#20142 (comment)

* Reorder list to match natural `portfile.cmake` order, as suggested by @dg0yt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants