-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg ci pipeline] suggest vcpkg_*_cmake -> vcpkg_cmake_* migration #20142
[vcpkg ci pipeline] suggest vcpkg_*_cmake -> vcpkg_cmake_* migration #20142
Conversation
e4c1251
to
ae77333
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated funktions are used. If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},{
"name": "vcpkg-cmake-config",
"host": true
}```
The following files are affected: ports/kf5textwidgets/portfile.cmake
ports/utfcpp/portfile.cmake
ae77333
to
aa1702b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used. If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
- ports/python3/portfile.cmake
- ports/utfcpp/portfile.cmake
aa1702b
to
f79357b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
f79357b
to
f7ed06f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
f7ed06f
to
e6cafdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/utfcpp/portfile.cmake
e6cafdc
to
e6fa54d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/armadillo/portfile.cmake
I have now moved the text into the Details so that the message is not so long. The PR is now ready. |
e6fa54d
to
12e5dff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR!
It's getting funky in here! :D |
That is just a german language party ;) (https://dict.leo.org/german-english/function) |
🎉🎉🎉🎉🎉🎉🎉🎈🎈🎈🎈🎈🎈🥳🥳🥳🥳🥳🥳🎈🎈🎈🎈🎈🎉🎉🎉🎉🎉 |
Dropping reviewed: This is good to go but I'm going to make sure other maintainers are OK with it (~11AM pacific tomorrow time) |
This should perhaps be backed by adding the deprecated functions to https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#avoid-deprecated-helper-functions. |
Thanks for your help! |
|
I just saw this in action in #19756 and it seems to look at some older commits in the PR, because its recommendation is off? |
@autoantwort Can you take a look at @wrobelda 's report? |
…guide. See discussion at microsoft#20142 (comment)
Another example where it did the wrong thing: #20207 |
I will look at it now |
Fix in #20218 |
…ide. (#20217) * Document deprecated functions from #20142 in the maintainer guide. See discussion at #20142 (comment) * Reorder list to match natural `portfile.cmake` order, as suggested by @dg0yt
…ide. (#20217) * Document deprecated functions from #20142 in the maintainer guide. See discussion at microsoft/vcpkg#20142 (comment) * Reorder list to match natural `portfile.cmake` order, as suggested by @dg0yt
…ide. (#20217) * Document deprecated functions from #20142 in the maintainer guide. See discussion at microsoft/vcpkg#20142 (comment) * Reorder list to match natural `portfile.cmake` order, as suggested by @dg0yt
No description provided.