-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[seal] Updated SEAL to version 3.7.0 #20166
Conversation
@WeiDaiWD, thanks for the PR! Please ignore the CI failures, it's a baseline issue, we're taking look at it now. |
Will you re-run the pipelines when the issue is fixed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 93a8320399e2f0b22877e097dc8216d5c634b8dd -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 4a187a2..844c4f2 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5930,7 +5930,7 @@
},
"seal": {
"baseline": "3.7.0",
- "port-version": 1
+ "port-version": 0
},
"secp256k1": {
"baseline": "2017-19-10",
diff --git a/versions/s-/seal.json b/versions/s-/seal.json
index d41205f..12337fb 100644
--- a/versions/s-/seal.json
+++ b/versions/s-/seal.json
@@ -1,9 +1,9 @@
{
"versions": [
{
- "git-tree": "9e7ac0590fc75966b948f977e1cf949ec2951668",
+ "git-tree": "7cd719565fadf0c9b04949d102daa65fb65d2efe",
"version-semver": "3.7.0",
- "port-version": 1
+ "port-version": 0
},
{
"git-tree": "89d120a6c3ac5306d90e29913048b518dc5a2c9b",
apsi with x64-windows-static, x64-windows-static-md, x64-linux and x64-osx failed in CI testsing, could you please take a look?
|
This is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/apsi/portfile.cmake
ports/ffnvcodec/portfile.cmake
ports/libproxy/portfile.cmake
ports/seal/portfile.cmake
I updated APSI too. |
@WeiDaiWD, thanks for your updates! All features test passed with x64-windows-static. |
Thanks for the new version! |
Describe the pull request
What does your PR fix?
Updated
ports/seal
to version 3.7.0.Which triplets are supported/not supported? Have you updated the CI baseline?
x64-windows/x86-windows are not supported as the library only supports static linkage in Windows.
No change to the CI baseline.
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes.
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/