Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[seal] Updated SEAL to version 3.7.0 #20166

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Conversation

WeiDaiWD
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

Updated ports/seal to version 3.7.0.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

x64-windows/x86-windows are not supported as the library only supports static linkage in Windows.
No change to the CI baseline.

Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes.

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@PhoebeHui PhoebeHui changed the title Updated SEAL to version 3.7.0 [seal] Updated SEAL to version 3.7.0 Sep 15, 2021
@PhoebeHui PhoebeHui self-assigned this Sep 15, 2021
@PhoebeHui PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Sep 15, 2021
ports/seal/vcpkg.json Outdated Show resolved Hide resolved
@PhoebeHui
Copy link
Contributor

@WeiDaiWD, thanks for the PR!

Please ignore the CI failures, it's a baseline issue, we're taking look at it now.

@WeiDaiWD
Copy link
Contributor Author

Will you re-run the pipelines when the issue is fixed?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 93a8320399e2f0b22877e097dc8216d5c634b8dd -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 4a187a2..844c4f2 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5930,7 +5930,7 @@
     },
     "seal": {
       "baseline": "3.7.0",
-      "port-version": 1
+      "port-version": 0
     },
     "secp256k1": {
       "baseline": "2017-19-10",
diff --git a/versions/s-/seal.json b/versions/s-/seal.json
index d41205f..12337fb 100644
--- a/versions/s-/seal.json
+++ b/versions/s-/seal.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "9e7ac0590fc75966b948f977e1cf949ec2951668",
+      "git-tree": "7cd719565fadf0c9b04949d102daa65fb65d2efe",
       "version-semver": "3.7.0",
-      "port-version": 1
+      "port-version": 0
     },
     {
       "git-tree": "89d120a6c3ac5306d90e29913048b518dc5a2c9b",

@PhoebeHui
Copy link
Contributor

apsi with x64-windows-static, x64-windows-static-md, x64-linux and x64-osx failed in CI testsing, could you please take a look?

CMake Error at C:/a/1/s/scripts/buildsystems/vcpkg.cmake:786 (_find_package):
  Could not find a configuration file for package "SEAL" that is compatible
  with requested version "3.6".

  The following configuration files were considered but not accepted:
    D:/installed/x64-windows-static/share/SEAL/SEALConfig.cmake, version: 3.7.0
Call Stack (most recent call first):
  CMakeLists.txt:111 (find_package)

@WeiDaiWD
Copy link
Contributor Author

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

This is resolved.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/apsi/portfile.cmake
  • ports/ffnvcodec/portfile.cmake
  • ports/libproxy/portfile.cmake
  • ports/seal/portfile.cmake

@WeiDaiWD
Copy link
Contributor Author

apsi with x64-windows-static, x64-windows-static-md, x64-linux and x64-osx failed in CI testsing, could you please take a look?

CMake Error at C:/a/1/s/scripts/buildsystems/vcpkg.cmake:786 (_find_package):
  Could not find a configuration file for package "SEAL" that is compatible
  with requested version "3.6".

  The following configuration files were considered but not accepted:
    D:/installed/x64-windows-static/share/SEAL/SEALConfig.cmake, version: 3.7.0
Call Stack (most recent call first):
  CMakeLists.txt:111 (find_package)

I updated APSI too.

@PhoebeHui PhoebeHui added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Sep 17, 2021
@PhoebeHui
Copy link
Contributor

PhoebeHui commented Sep 17, 2021

@WeiDaiWD, thanks for your updates!

All features test passed with x64-windows-static.
Except feature hexl and zstd which support static, other features test passed with x64-windows.

@PhoebeHui PhoebeHui removed requires:author-response requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Sep 17, 2021
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 17, 2021
@BillyONeal BillyONeal merged commit ccd2cf0 into microsoft:master Sep 17, 2021
@BillyONeal
Copy link
Member

Thanks for the new version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants