-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[neon2sse] create a new port #20200
Merged
Merged
[neon2sse] create a new port #20200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoebeHui
added
the
category:new-port
The issue is requesting a new library to be added; consider making a PR!
label
Sep 17, 2021
PhoebeHui
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR!
BillyONeal
reviewed
Sep 17, 2021
BillyONeal
added
requires:author-response
and removed
info:reviewed
Pull Request changes follow basic guidelines
labels
Sep 17, 2021
Indeed that would be great.
The project uses its name for config file generation.
So config fix up of `NEON_2_SSE` to `neon2sse` will break find_package with
neon2sse.
I thought matching port name and project looks better.
…On Sat, Sep 18, 2021, 12:19 AM BillyONeal ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ports/neon2sse/fix-cmakelists.patch
<#20200 (comment)>:
> @@ -0,0 +1,13 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index e4b8980..231b75e 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -2,7 +2,7 @@
+ # Modification: Copyright (C) 2017 David Hirvonen
+
+ cmake_minimum_required(VERSION 3.0)
+-project(NEON_2_SSE VERSION 1.0.0)
++project(neon2sse VERSION 1.0.0)
(If you remove the patch, the vcpkg_cmake_config_fixup call must be
changed to vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/NEON_2_SSE))
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20200 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLSYE6P2RBEAOBZ24SYQWDUCNL6VANCNFSM5EEW4SYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Yes, I think it looks better too, but it also forces people who get this from vcpkg to use a different |
Hmm... I will use package name 'NEON_2_SSE' instead.
No patch file, no complexity. I agree.
…On Sat, Sep 18, 2021, 12:34 AM Dong-Ha Park ***@***.***> wrote:
Indeed that would be great.
The project uses its name for config file generation.
So config fix up of `NEON_2_SSE` to `neon2sse` will break find_package
with neon2sse.
I thought matching port name and project looks better.
On Sat, Sep 18, 2021, 12:19 AM BillyONeal ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In ports/neon2sse/fix-cmakelists.patch
> <#20200 (comment)>:
>
> > @@ -0,0 +1,13 @@
> +diff --git a/CMakeLists.txt b/CMakeLists.txt
> +index e4b8980..231b75e 100644
> +--- a/CMakeLists.txt
> ++++ b/CMakeLists.txt
> +@@ -2,7 +2,7 @@
> + # Modification: Copyright (C) 2017 David Hirvonen
> +
> + cmake_minimum_required(VERSION 3.0)
> +-project(NEON_2_SSE VERSION 1.0.0)
> ++project(neon2sse VERSION 1.0.0)
>
> (If you remove the patch, the vcpkg_cmake_config_fixup call must be
> changed to vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/NEON_2_SSE))
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#20200 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADLSYE6P2RBEAOBZ24SYQWDUCNL6VANCNFSM5EEW4SYA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
|
Thanks for the new port! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Add a library
neon2sse
. https://github.com/intel/ARM_NEON_2_x86_SSEThis project provides 1 header file and supports
find_package
for CMake projects.Which triplets are supported/not supported? Have you updated the CI baseline?
This is a header only. So every triplet must be available.
Does your PR follow the maintainer guide?
I think so