Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libunifex] Update to 2021-11-06 #21483

Closed
wants to merge 6 commits into from
Closed

Conversation

zeyangl
Copy link
Contributor

@zeyangl zeyangl commented Nov 17, 2021

Describe the pull request

  • What does your PR fix?

    Update libunifex to 2021-11-06

  • Which triplets are supported/not supported? Have you updated the CI baseline?

all previously supported triplet.

yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link

ghost commented Nov 17, 2021

CLA assistant check
All CLA requirements met.

@JonLiu1993 JonLiu1993 self-assigned this Nov 17, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 17, 2021
ports/libunifex/vcpkg.json Outdated Show resolved Hide resolved
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
@JonLiu1993
Copy link
Member

@zeyangl ,Have you tested the feature locally?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout a4b5cde7f504c1bbbbc455f4a6ee60efd9034772 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 00c7df6..c4a02fd 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3974,7 +3974,7 @@
     },
     "libunifex": {
       "baseline": "2021-11-06",
-      "port-version": 1
+      "port-version": 0
     },
     "libunistring": {
       "baseline": "0.9.10",
diff --git a/versions/l-/libunifex.json b/versions/l-/libunifex.json
index 5a16d06..807194c 100644
--- a/versions/l-/libunifex.json
+++ b/versions/l-/libunifex.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "cbcfbaf64f316e802c5e84a3a71ecdd390979abb",
+      "git-tree": "026508227fab71e346483fbfe3f349981f31de86",
       "version-date": "2021-11-06",
-      "port-version": 1
+      "port-version": 0
     },
     {
       "git-tree": "7c98590771b98cb8c31e49867e78983853307a1f",

@zeyangl
Copy link
Contributor Author

zeyangl commented Nov 17, 2021

I did not try the version with port version removed. I'll do that later. Need to look up what port version means. I tried my previous commits and appear to compile fine.

@JonLiu1993
Copy link
Member

Please run command "./vcpkg x-add-version libunifex --overwrite-version " and commit again

@zeyangl
Copy link
Contributor Author

zeyangl commented Nov 17, 2021

Tried the full pr and works fine on locally.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout a4b5cde7f504c1bbbbc455f4a6ee60efd9034772 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libunifex.json b/versions/l-/libunifex.json
index fe32e26..807194c 100644
--- a/versions/l-/libunifex.json
+++ b/versions/l-/libunifex.json
@@ -5,11 +5,6 @@
       "version-date": "2021-11-06",
       "port-version": 0
     },
-    {
-      "git-tree": "cbcfbaf64f316e802c5e84a3a71ecdd390979abb",
-      "version-date": "2021-11-06",
-      "port-version": 1
-    },
     {
       "git-tree": "7c98590771b98cb8c31e49867e78983853307a1f",
       "version-date": "2021-08-01",

versions/l-/libunifex.json Outdated Show resolved Hide resolved
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
@JonLiu1993 JonLiu1993 added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function and removed requires:author-response labels Nov 17, 2021
@zeyangl
Copy link
Contributor Author

zeyangl commented Nov 17, 2021

First time submitting a pr for vcpkg. Is there anything else I should do?

@JonLiu1993 JonLiu1993 removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Nov 18, 2021
@JonLiu1993
Copy link
Member

@zeyangl ,Thanks for your pr,I tested the features 'test' in x64-windows locally but failed, Could you please take a look:
install-x86-windows-dbg-out.log

@zeyangl
Copy link
Contributor Author

zeyangl commented Nov 18, 2021

Yeah will do later today.

@JonLiu1993
Copy link
Member

@zeyangl ,Is there any progress?

@zeyangl
Copy link
Contributor Author

zeyangl commented Nov 23, 2021 via email

@JonLiu1993
Copy link
Member

harddrive died and took a while to re-setup. I'll look into this test issue, but it's unlikely to be resolved, I'm not the developer of this library, just an active user. The current version is the head version from its git repo and maybe it's just not compiling the tests. If that's the case is it okay to remove the test option and leave only the library itself?

On Tue, Nov 23, 2021 at 10:42 AM JonLiu1993 @.***> wrote: @zeyangl https://github.com/zeyangl ,Is there any progress? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21483 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJP3PUSTKLXMJP4ONWMASTUNL5TDANCNFSM5IGCLQFA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

The "test" function mainly provides the "build test/sample program" function. In my opinion, it is not good to delete directly to solve this problem. You can try to solve it first

@zeyangl
Copy link
Contributor Author

zeyangl commented Nov 24, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants