Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libgit2] Add Exported CMake Targets #21670

Merged
merged 5 commits into from
Nov 28, 2021
Merged

[libgit2] Add Exported CMake Targets #21670

merged 5 commits into from
Nov 28, 2021

Conversation

LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL commented Nov 26, 2021

Fixes #21523
Add Exported CMake Targets for libgit2, and fix dependency dll not found on Debug.
Already test usage, pass.

@LilyWangLL LilyWangLL added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support labels Nov 26, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout a2fcb03749ff5897b5985092934dc6057680c789 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libgit2.json b/versions/l-/libgit2.json
index 76203ba..569efb2 100644
--- a/versions/l-/libgit2.json
+++ b/versions/l-/libgit2.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "218bdc4178691017528f101ef4f21add29af0dd1",
+      "git-tree": "db898a66ff6c854875a9df8fc7609e59952ad505",
       "version-semver": "1.3.0",
       "port-version": 2
     },

@JackBoosY JackBoosY marked this pull request as ready for review November 26, 2021 07:00
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Nov 26, 2021
@BillyONeal BillyONeal merged commit 3a68454 into microsoft:master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vcpkg dlls only copied in release profile CMAKE builds, debug profile builds unable to run
3 participants