-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blas] Add custom FindBLAS.cmake to openblas #22305
[blas] Add custom FindBLAS.cmake to openblas #22305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for openblas but no changes to version or port version.
-- Version: 0.3.15#1
-- Old SHA: 048ae3833af8e5633ce86c3174e20c2794fe573d
-- New SHA: acaedcaeb850681e2e63c11552540ed0d5073a10
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for openblas but no changes to version or port version.
-- Version: 0.3.15#1
-- Old SHA: 048ae3833af8e5633ce86c3174e20c2794fe573d
-- New SHA: 849109745cbbe778c4a72f1cf1019d73fc59aa74
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Okay, seems like this solves issues with x64-linux-dynamic but now fails some libraries in other triplets... need to find some time to look into these issues. |
Needs to be considered in concert with #21479 |
Draft this PR until we decide to pick one of the relevant PRs. |
Closing this PR since it seems that no progress is being made. Please reopen if work is still being done. |
Fixes issue #15192 by shipping a custom FindBLAS.cmake script that reuses the exported CMake config from OpenBLAS directly to set the appropriate BLAS output variables and targets. This logic is inspired by the existing custom FindLAPACK.cmake shipped by the clapack package.