Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lunasvg] Add new port #23867

Merged
merged 10 commits into from
Apr 5, 2022
Merged

[lunasvg] Add new port #23867

merged 10 commits into from
Apr 5, 2022

Conversation

Pospelove
Copy link
Contributor

closes #15432

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for lunasvg but no changes to version or port version.
-- Version: 2.3.1
-- Old SHA: 21eb4e9b6cb5106d010be467d209312971e8c716
-- New SHA: 8e4dee5a2abd2f3eb797f096fef74ca915db37a9
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/lunasvg/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for lunasvg but no changes to version or port version.
-- Version: 2.3.1
-- Old SHA: 21eb4e9b6cb5106d010be467d209312971e8c716
-- New SHA: 06b306e2058a6765192432378ebd3d836a036d05
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/lunasvg/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for lunasvg but no changes to version or port version.
-- Version: 2.3.1
-- Old SHA: 21eb4e9b6cb5106d010be467d209312971e8c716
-- New SHA: 06b306e2058a6765192432378ebd3d836a036d05
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/lunasvg/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for lunasvg but no changes to version or port version.
-- Version: 2.3.1
-- Old SHA: 06b306e2058a6765192432378ebd3d836a036d05
-- New SHA: fc0644978fa96410ca02b88071ff241114812ccf
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@JonLiu1993 JonLiu1993 self-assigned this Mar 30, 2022
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 30, 2022
@Pospelove
Copy link
Contributor Author

@JonLiu1993 We probably should accept accept as it is and update the port in other PR. This bugfix doesn't seem essential. And the last released version of the lib is still 2.3.1

@Pospelove
Copy link
Contributor Author

@JonLiu1993 Or I can use latest commit and call version 2.3.1-1 in the vcpkg.json file. Is it an option?

@JonLiu1993
Copy link
Member

@JonLiu1993 Or I can use latest commit and call version 2.3.1-1 in the vcpkg.json file. Is it an option?

If Upstream doesn't explicitly state that uwp is not supported, we can't arbitrarily add the supports field unless there is favorable evidence

@Pospelove
Copy link
Contributor Author

@JonLiu1993 Sorry? I guess it was another my PR with supports field changed 😄

@Pospelove
Copy link
Contributor Author

Oops. I see. It's a typo actually.

ports/lunasvg/vcpkg.json Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for lunasvg but no changes to version or port version.
-- Version: 2.3.1
-- Old SHA: c7306eecf5188e62df1ca79183f8b6d0ee209dab
-- New SHA: bf20380ca537151f7d1e02a6ca5b19c302db18c7
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Apr 1, 2022
@Pospelove
Copy link
Contributor Author

@JonLiu1993 🥺 🙏

@strega-nil-ms
Copy link
Contributor

Thanks!

@strega-nil-ms strega-nil-ms merged commit 6dff39f into microsoft:master Apr 5, 2022
@Pospelove Pospelove deleted the add-lunasvg branch April 5, 2022 18:08
@spaxio
Copy link
Contributor

spaxio commented Apr 21, 2022

Thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] lunasvg
4 participants