-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[directxtk, directxtk12, directxtex, directxmesh, uvatlas] Update ports for May 2022 release #24650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbourn
commented
May 11, 2022
JonLiu1993
added
category:port-update
The issue is with a library, which is requesting update new revision
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
labels
May 11, 2022
All features are tested successfully in the following triplet:
|
JonLiu1993
approved these changes
May 11, 2022
Validated building all supported features and triplets locally:
|
Building directxtk, direcxtk12, or directxtex with MinG-W32 requires:
Building directxtk, direcxtk12, or directxtex with MinG-W64 requires:
|
Thanks for the updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
category:port-update
The issue is with a library, which is requesting update new revision
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirectX Tool Kit for DX11 / DX12, DirectXTex, DirectXMesh, and UVAtlas all have new May 2022 releases on GitHub. In addition to a few bug fixes and minor features, this revision adds support for building with the MinGW toolset via CMake.
All ports now support building with x86-mingw-static and x64-mingw-static community triplets when using MinGW GNU 11. The directxtk, directxtk12, and directxtex ports also need the HLSL compiler in the path along with the appropriate compiler toolset. These ports all take advantage of the recent changes to directx-headers including conformance fixes for MinGW (#24490).
The directxtk12 port now exposes an xaudio2-9 and xaudio2redist feature because MinGW requires xaudio2redist to build (if xaudio2-9 is specified, the upstream CMake just turns it off if using MinGW). Therefore, to get DirectX Tool Kit for Audio support with either the directxtk or directxtk12 ports when using MinGW, you need to use the xaudio2redist feature.