Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boringssl] Remove -WX and -Werror #24899

Merged
merged 8 commits into from
Jun 2, 2022

Conversation

rpavlik
Copy link
Contributor

@rpavlik rpavlik commented May 24, 2022

…VS2022.

Filed upstream as https://bugs.chromium.org/p/boringssl/issues/detail?id=495

Describe the pull request

  • What does your PR fix?

Build of boringssl broken as noted in #24310 (comment)

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Only affects windows. Did not update the baseline.

Well, it adds a patch for a non-vcpkg-specific problem, but I did file it upstream too.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 25, 2022
@LilyWangLL LilyWangLL changed the title boringssl: Add a patch to disable another warning breaking build for … [boringssl] Add a patch to disable another warning C4191 May 25, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/boringssl/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/boringssl/vcpkg.json

Valid values for the license field can be found in the documentation

ports/boringssl/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangLL
Copy link
Contributor

Ping @rpavlik

@rpavlik
Copy link
Contributor Author

rpavlik commented May 28, 2022

Haven't had time to do the requested extra maintenance, and won't for a couple of weeks.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/boringssl/vcpkg.json

Valid values for the license field can be found in the documentation

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 30, 2022
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ras0219-msft ras0219-msft removed the info:reviewed Pull Request changes follow basic guidelines label May 31, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/boringssl/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/boringssl/vcpkg.json

Valid values for the license field can be found in the documentation

@LilyWangLL LilyWangLL changed the title [boringssl] Add a patch to disable another warning C4191 [boringssl] Add -WX and -Werror to disable all warning Jun 2, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 2, 2022
@ras0219-msft ras0219-msft changed the title [boringssl] Add -WX and -Werror to disable all warning [boringssl] Remove -WX and -Werror Jun 2, 2022
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ras0219-msft ras0219-msft merged commit 850ba1a into microsoft:master Jun 2, 2022
@rpavlik rpavlik deleted the boringssl-patch branch June 14, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants