[SDL] enable hidapi #25022
Merged
[SDL] enable hidapi #25022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
category:port-feature
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f78f4440df86358575dea65e748a39fdad41eb85 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 17f6044..dd1f46a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6406,7 +6406,7 @@
},
"sdl2": {
"baseline": "2.0.22",
- "port-version": 0
+ "port-version": 1
},
"sdl2-gfx": {
"baseline": "1.0.4",
diff --git a/versions/s-/sdl2.json b/versions/s-/sdl2.json
index 17383fd..2d5eb6a 100644
--- a/versions/s-/sdl2.json
+++ b/versions/s-/sdl2.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "879012d1bbd3ae67fc697109eedbe6ff713c2c34",
+ "version": "2.0.22",
+ "port-version": 1
+ },
{
"git-tree": "6d875fe2feac0480f61fcf890136e045c12429f1",
"version": "2.0.22",
FrankXie05
approved these changes
Jun 2, 2022
ras0219-msft
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
This LGTM because
- SDL seems to have modified/improved the implementation
- They rename the symbols to avoid ODR violations (Rename hidapi symbols to prevent static linking issues libsdl-org/SDL#4602)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [SDL] enable hidapi #19252SDL uses HIDAPI for some game controller features, most notably access to the gyroscope and accelerometer data. This isn't included currently in vcpkg, so only the buttons and joysticks work.
SDL uses its own bundled hidapi version, so we should just need to enable the DSDL_HIDAPI_JOYSTICK=ON cmake flag