-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BlingFire] Adding BlingFire Package #28304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for blingfire have changed but the version was not updated
version: 0.1.8.1
old SHA: eaec4e8f6c06aab2b45efeb9390ad254d6bf26f6
new SHA: 116f5d9d79316a7186a821bfb0c02607cb4e4b8c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
@TomasMorris, when I install this port on my local machine, I find no xxxconfig.cmake in package file but Upstream code have this code, could you please take a look?
|
9c07875
codebase didn't include a cmake config, I have updated BlingFire to include that and updated the commit in this port to match. |
@TomasMorris, when I tested the usage by a simple cmake project, I got this error.
CMakeProject42.cpp:
CMakeProject42.h:
|
Pinging @TomasMorris for response. |
Convert this PR to draft since there is no progress. Please ping us if this PR is ready for review again. |
Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done. |
Sorry for the break, took some time off. @JonLiu1993, would you mind reopening this as it should be ready for review and all the issues above were fixed. |
@TomasMorris, this PR cannot be reopened, thinking that the branch |
What does your PR fix?
Adds a BlingFire port
Which triplets are supported/not supported? Have you updated the CI baseline?
Windows x64, Yes
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes