[aws-sdk-cpp] update port to v1.11.65 #30197

anders-wind · 2023-03-15T08:55:37Z

This PR updates the aws-sdk-cpp from v1.11.4 to v1.11.65.
Fixes #31090

Changes comply with the maintainer guide
SHA512s are updated for each updated download
~~The "supports" clause reflects platforms that may be fixed by this new version~~
~~Any fixed CI baseline entries are removed from that file.~~
~~Any patches that are no longer applied are deleted from the port's directory.~~
The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
Only one version is added to each modified port's versions file.

Updating because they fixed a memory leak which is blocking us from updating to the newest vcpkg release.

anders-wind · 2023-03-15T09:11:28Z

Should I still tick the 3 missing check boxes if I don't think this PR affects those points?

anders-wind · 2023-03-15T09:14:44Z

I see that the patches don't work anymore. I'll try to see if I can fix that.
EDIT: Done

anders-wind · 2023-03-15T09:40:38Z

The windows build error seem to be related to a warning being treated as an error (install-x64-windows-dbg-out.log):

[70/77] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\cl.exe   /TP -DAWS_AUTH_USE_IMPORT_EXPORT -DAWS_CAL_USE_IMPORT_EXPORT -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_COMPRESSION_USE_IMPORT_EXPORT -DAWS_CORE_EXPORTS=1 -DAWS_CRT_CPP_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_HTTP_USE_IMPORT_EXPORT -DAWS_IO_USE_IMPORT_EXPORT -DAWS_MQTT_USE_IMPORT_EXPORT -DAWS_MQTT_WITH_WEBSOCKETS -DAWS_S3_USE_IMPORT_EXPORT -DAWS_SDKUTILS_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=11 -DAWS_SDK_VERSION_PATCH=37 -DAWS_TEST_REGION=US_EAST_1 -DAWS_USE_IO_COMPLETION_PORTS -DENABLED_REQUEST_COMPRESSION -DENABLED_ZLIB_REQUEST_COMPRESSION -DENABLE_BCRYPT_ENCRYPTION -DENABLE_CURL_LOGGING -DENABLE_WINDOWS_CLIENT -DPLATFORM_WINDOWS -DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -DWINHTTP_HAS_H2 -DWININET_HAS_H2 -Daws_cpp_sdk_core_EXPORTS -ID:\buildtrees\aws-sdk-cpp\src\1.11.37-4e3e990eb0.clean\src\aws-cpp-sdk-core\include\aws\core\platform\refs -ID:\buildtrees\aws-sdk-cpp\src\1.11.37-4e3e990eb0.clean\src\aws-cpp-sdk-core\include -external:ID:\installed\x64-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W4 /utf-8 /GR /EHsc /MP  /MP /bigobj /utf-8 /WX /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Fosrc\aws-cpp-sdk-core\CMakeFiles\aws-cpp-sdk-core.dir\ub_core.cpp.obj /Fdsrc\aws-cpp-sdk-core\CMakeFiles\aws-cpp-sdk-core.dir\ /FS -c D:\buildtrees\aws-sdk-cpp\x64-windows-dbg\src\aws-cpp-sdk-core\ub_core.cpp
FAILED: src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/ub_core.cpp.obj 
C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\cl.exe   /TP -DAWS_AUTH_USE_IMPORT_EXPORT -DAWS_CAL_USE_IMPORT_EXPORT -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_COMPRESSION_USE_IMPORT_EXPORT -DAWS_CORE_EXPORTS=1 -DAWS_CRT_CPP_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_HTTP_USE_IMPORT_EXPORT -DAWS_IO_USE_IMPORT_EXPORT -DAWS_MQTT_USE_IMPORT_EXPORT -DAWS_MQTT_WITH_WEBSOCKETS -DAWS_S3_USE_IMPORT_EXPORT -DAWS_SDKUTILS_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=11 -DAWS_SDK_VERSION_PATCH=37 -DAWS_TEST_REGION=US_EAST_1 -DAWS_USE_IO_COMPLETION_PORTS -DENABLED_REQUEST_COMPRESSION -DENABLED_ZLIB_REQUEST_COMPRESSION -DENABLE_BCRYPT_ENCRYPTION -DENABLE_CURL_LOGGING -DENABLE_WINDOWS_CLIENT -DPLATFORM_WINDOWS -DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -DWINHTTP_HAS_H2 -DWININET_HAS_H2 -Daws_cpp_sdk_core_EXPORTS -ID:\buildtrees\aws-sdk-cpp\src\1.11.37-4e3e990eb0.clean\src\aws-cpp-sdk-core\include\aws\core\platform\refs -ID:\buildtrees\aws-sdk-cpp\src\1.11.37-4e3e990eb0.clean\src\aws-cpp-sdk-core\include -external:ID:\installed\x64-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W4 /utf-8 /GR /EHsc /MP  /MP /bigobj /utf-8 /WX /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Fosrc\aws-cpp-sdk-core\CMakeFiles\aws-cpp-sdk-core.dir\ub_core.cpp.obj /Fdsrc\aws-cpp-sdk-core\CMakeFiles\aws-cpp-sdk-core.dir\ /FS -c D:\buildtrees\aws-sdk-cpp\x64-windows-dbg\src\aws-cpp-sdk-core\ub_core.cpp
D:/buildtrees/aws-sdk-cpp/src/1.11.37-4e3e990eb0.clean/src/aws-cpp-sdk-core/source/client/RequestCompression.cpp(159): error C2220: the following warning is treated as an error
D:/buildtrees/aws-sdk-cpp/src/1.11.37-4e3e990eb0.clean/src/aws-cpp-sdk-core/source/client/RequestCompression.cpp(159): warning C4267: '=': conversion from 'size_t' to 'uInt', possible loss of data
D:/buildtrees/aws-sdk-cpp/src/1.11.37-4e3e990eb0.clean/src/aws-cpp-sdk-core/source/client/RequestCompression.cpp(280): warning C4267: '=': conversion from 'size_t' to 'uInt', possible loss of data
[71/77] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\cl.exe   /TP -DAWS_AUTH_USE_IMPORT_EXPORT -DAWS_CAL_USE_IMPORT_EXPORT -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_COMPRESSION_USE_IMPORT_EXPORT -DAWS_CRT_CPP_USE_IMPORT_EXPORT -DAWS_DYNAMODB_EXPORTS -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_HTTP_USE_IMPORT_EXPORT -DAWS_IO_USE_IMPORT_EXPORT -DAWS_MQTT_USE_IMPORT_EXPORT -DAWS_MQTT_WITH_WEBSOCKETS -DAWS_S3_USE_IMPORT_EXPORT -DAWS_SDKUTILS_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=11 -DAWS_SDK_VERSION_PATCH=37 -DAWS_TEST_REGION=US_EAST_1 -DAWS_USE_IO_COMPLETION_PORTS -DENABLED_REQUEST_COMPRESSION -DENABLED_ZLIB_REQUEST_COMPRESSION -DENABLE_BCRYPT_ENCRYPTION -DENABLE_WINDOWS_CLIENT -DPLATFORM_WINDOWS -DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -Daws_cpp_sdk_dynamodb_EXPORTS -ID:\buildtrees\aws-sdk-cpp\src\1.11.37-4e3e990eb0.clean\generated\src\aws-cpp-sdk-dynamodb\include -ID:\buildtrees\aws-sdk-cpp\src\1.11.37-4e3e990eb0.clean\src\aws-cpp-sdk-core\include -external:ID:\installed\x64-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W4 /utf-8 /GR /EHsc /MP  /MP /bigobj /utf-8 /WX /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Fogenerated\src\aws-cpp-sdk-dynamodb\CMakeFiles\aws-cpp-sdk-dynamodb.dir\ub_DYNAMODB.cpp.obj /Fdgenerated\src\aws-cpp-sdk-dynamodb\CMakeFiles\aws-cpp-sdk-dynamodb.dir\ /FS -c D:\buildtrees\aws-sdk-cpp\x64-windows-dbg\generated\src\aws-cpp-sdk-dynamodb\ub_DYNAMODB.cpp
[72/77] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\cl.exe   /TP -DAWS_AUTH_USE_IMPORT_EXPORT -DAWS_CAL_USE_IMPORT_EXPORT -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_COMPRESSION_USE_IMPORT_EXPORT -DAWS_CRT_CPP_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_HTTP_USE_IMPORT_EXPORT -DAWS_IO_USE_IMPORT_EXPORT -DAWS_MQTT_USE_IMPORT_EXPORT -DAWS_MQTT_WITH_WEBSOCKETS -DAWS_S3_EXPORTS -DAWS_S3_USE_IMPORT_EXPORT -DAWS_SDKUTILS_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=11 -DAWS_SDK_VERSION_PATCH=37 -DAWS_TEST_REGION=US_EAST_1 -DAWS_USE_IO_COMPLETION_PORTS -DENABLED_REQUEST_COMPRESSION -DENABLED_ZLIB_REQUEST_COMPRESSION -DENABLE_BCRYPT_ENCRYPTION -DENABLE_WINDOWS_CLIENT -DPLATFORM_WINDOWS -DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -Daws_cpp_sdk_s3_EXPORTS -ID:\buildtrees\aws-sdk-cpp\src\1.11.37-4e3e990eb0.clean\generated\src\aws-cpp-sdk-s3\include -ID:\buildtrees\aws-sdk-cpp\src\1.11.37-4e3e990eb0.clean\src\aws-cpp-sdk-core\include -external:ID:\installed\x64-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W4 /utf-8 /GR /EHsc /MP  /MP /bigobj /utf-8 /WX /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Fogenerated\src\aws-cpp-sdk-s3\CMakeFiles\aws-cpp-sdk-s3.dir\ub_S3.cpp.obj /Fdgenerated\src\aws-cpp-sdk-s3\CMakeFiles\aws-cpp-sdk-s3.dir\ /FS -c D:\buildtrees\aws-sdk-cpp\x64-windows-dbg\generated\src\aws-cpp-sdk-s3\ub_S3.cpp
ninja: build stopped: subcommand failed.

I'm a bit in doubt on how to solve this, so any feedback would be appreciated.

autoantwort · 2023-03-15T13:11:11Z

I'm a bit in doubt on how to solve this, so any feedback would be appreciated.

Patch the /Wx out :)

anders-wind · 2023-03-15T14:22:28Z

Patch the /Wx out :)

Ah yea okay that was simple.

jimwang118 · 2023-03-17T06:06:55Z

I got an error when I installed the verification locally, please fix this problem, thank you.
step：
.\vcpkg.exe install aws-sdk-cpp[*]:x64-windows
log:

E:/aws-sdk-cpp/vcpkg/installed -DVCPKG_MANIFEST_INSTALL=OFF
    Working Directory: E:/aws-sdk-cpp/vcpkg/buildtrees/aws-sdk-cpp/x64-windows-dbg
    Error code: 1
    See logs for more information:
      E:\aws-sdk-cpp\vcpkg\buildtrees\aws-sdk-cpp\config-x64-windows-dbg-CMakeCache.txt.log
      E:\aws-sdk-cpp\vcpkg\buildtrees\aws-sdk-cpp\config-x64-windows-dbg-out.log
      E:\aws-sdk-cpp\vcpkg\buildtrees\aws-sdk-cpp\config-x64-windows-dbg-err.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:263 (vcpkg_execute_required_process)
  ports/aws-sdk-cpp/portfile.cmake:36 (vcpkg_cmake_configure)
  scripts/ports.cmake:147 (include)


error: building aws-sdk-cpp:x64-windows failed with: BUILD_FAILED
error: Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
    https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+aws-sdk-cpp
You can submit a new issue at:
    https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[aws-sdk-cpp]+Build+error
Include '[aws-sdk-cpp] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
    vcpkg-tool version: 2023-03-14-105f7f7e8a5ea10dfac9874ff9d1a6bacba5f454
    vcpkg-scripts version: 02af59c23 2023-03-15 (2 days ago)

anders-wind · 2023-03-17T06:23:41Z

"Unfortunately" I'm on vacation for the next 5 weeks. I'll ping one from my team, but I doubt they will have time to fix it.

jimwang118 · 2023-03-17T08:38:35Z

"Unfortunately" I'm on vacation for the next 5 weeks. I'll ping one from my team, but I doubt they will have time to fix it.

Ok, I'll try to fix it as well as I can.

jimwang118 · 2023-04-25T05:51:22Z

@anders-wind Do you have time now to fix its installation issues?

anders-wind · 2023-04-25T08:00:54Z

Yea just arrived home - I'll try to fix it first by updating to the latest version.

I dont have access to a windows machine, could you possibly send me the error logs? I also doesnt seem to fail in the CI workflow.

LilyWangLL · 2023-04-25T08:39:54Z

@anders-wind Upstream has removed deprecated feature mobileanalytics, please remove it from vcpkg.json. The related upstream link: aws/aws-sdk-cpp#2163

anders-wind · 2023-04-25T09:05:28Z

@anders-wind Upstream has removed deprecated feature mobileanalytics, please remove it from vcpkg.json. The related upstream link: aws/aws-sdk-cpp#2163

Done 👍

jimwang118 · 2023-04-26T08:34:48Z

The usage and feature has been tested successfully locally.

find_package(aws-cpp-sdk-core REQUIRED)
target_include_directories(main PRIVATE aws-cpp-sdk-core)
target_link_libraries(main PRIVATE aws-cpp-sdk-core)

BillyONeal · 2023-04-26T19:12:10Z

Thanks for the update!

anders-wind force-pushed the port_update/aws_sdk_cpp branch from 648060c to 3da7297 Compare March 15, 2023 08:56

JonLiu1993 assigned jimwang118 Mar 15, 2023

anders-wind force-pushed the port_update/aws_sdk_cpp branch from 3da7297 to 28d6994 Compare March 15, 2023 09:10

jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Mar 15, 2023

anders-wind force-pushed the port_update/aws_sdk_cpp branch from 28d6994 to 84b391e Compare March 15, 2023 09:23

anders-wind force-pushed the port_update/aws_sdk_cpp branch from 84b391e to 02af59c Compare March 15, 2023 13:38

jimwang118 added the requires:author-response label Mar 17, 2023

jimwang118 marked this pull request as draft April 25, 2023 05:46

anders-wind force-pushed the port_update/aws_sdk_cpp branch from 880841a to 5c34753 Compare April 25, 2023 08:08

LilyWangLL changed the title ~~[aws-sdk-cpp] update port to v1.11.37~~ [aws-sdk-cpp] update port to v1.11.65 Apr 25, 2023

[aws-sdk-cpp] update port to v1.11.37

1de054a

anders-wind force-pushed the port_update/aws_sdk_cpp branch from 2735899 to 1de054a Compare April 25, 2023 08:47

anders-wind marked this pull request as ready for review April 25, 2023 13:08

LilyWangLL approved these changes Apr 26, 2023

View reviewed changes

LilyWangLL requested a review from jimwang118 April 26, 2023 02:37

jimwang118 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 26, 2023

jimwang118 approved these changes Apr 26, 2023

View reviewed changes

BillyONeal merged commit c74f787 into microsoft:master Apr 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[aws-sdk-cpp] update port to v1.11.65 #30197

[aws-sdk-cpp] update port to v1.11.65 #30197

anders-wind commented Mar 15, 2023 •

edited by LilyWangLL

Loading

anders-wind commented Mar 15, 2023 •

edited

Loading

anders-wind commented Mar 15, 2023 •

edited

Loading

anders-wind commented Mar 15, 2023 •

edited

Loading

autoantwort commented Mar 15, 2023

anders-wind commented Mar 15, 2023 •

edited

Loading

jimwang118 commented Mar 17, 2023

anders-wind commented Mar 17, 2023

jimwang118 commented Mar 17, 2023

jimwang118 commented Apr 25, 2023

anders-wind commented Apr 25, 2023 •

edited

Loading

LilyWangLL commented Apr 25, 2023

anders-wind commented Apr 25, 2023

jimwang118 commented Apr 26, 2023

BillyONeal commented Apr 26, 2023

[aws-sdk-cpp] update port to v1.11.65 #30197

[aws-sdk-cpp] update port to v1.11.65 #30197

Conversation

anders-wind commented Mar 15, 2023 • edited by LilyWangLL Loading

anders-wind commented Mar 15, 2023 • edited Loading

anders-wind commented Mar 15, 2023 • edited Loading

anders-wind commented Mar 15, 2023 • edited Loading

autoantwort commented Mar 15, 2023

anders-wind commented Mar 15, 2023 • edited Loading

jimwang118 commented Mar 17, 2023

anders-wind commented Mar 17, 2023

jimwang118 commented Mar 17, 2023

jimwang118 commented Apr 25, 2023

anders-wind commented Apr 25, 2023 • edited Loading

LilyWangLL commented Apr 25, 2023

anders-wind commented Apr 25, 2023

jimwang118 commented Apr 26, 2023

BillyONeal commented Apr 26, 2023

anders-wind commented Mar 15, 2023 •

edited by LilyWangLL

Loading

anders-wind commented Mar 15, 2023 •

edited

Loading

anders-wind commented Mar 15, 2023 •

edited

Loading

anders-wind commented Mar 15, 2023 •

edited

Loading

anders-wind commented Mar 15, 2023 •

edited

Loading

anders-wind commented Apr 25, 2023 •

edited

Loading