Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg_configure_make] Fix processing of CMAKE_<LANG>_STANDARD_LIBRARIES #30381

Closed
wants to merge 8 commits into from

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Mar 23, 2023

Linker flags must be preserved, not prefixed with -l.
Fixes #30327.
Tested with libpq:arm-android (reproducer), libpq:x64-mingw-dynamic (w.r.t. -luuid).

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Adela0814 Adela0814 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Mar 23, 2023
@dg0yt dg0yt mentioned this pull request Apr 28, 2023
7 tasks
@dg0yt dg0yt mentioned this pull request May 3, 2023
2 tasks
@Adela0814
Copy link
Contributor

@dg0yt Can this be duplicate to #31228?

@dg0yt
Copy link
Contributor Author

dg0yt commented May 9, 2023

@dg0yt Can this be duplicate to #31228?

Not so much. This PR (30381) is complete and done and fixes one particular issue.
#31228 includes it so that it is possible do minimize the number of rebuilds on the user side. But is entirely unpredictable how it will pass through baseline regression and review. So you must decide if you can approve #31228 soon enough.

@Adela0814
Copy link
Contributor

We will review and approve #31228 as soon as possible, I will be converting your PR to draft status.

@Adela0814 Adela0814 marked this pull request as draft May 10, 2023 09:13
@dg0yt
Copy link
Contributor Author

dg0yt commented May 22, 2023

Closing in favor of #31228.

@dg0yt dg0yt closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libpq] build failure [android]
2 participants