Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libheif] Fix error when libgdk-pixbuf2.0-dev installed in linux #30999

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

Cheney-W
Copy link
Contributor

Fixes #29156

gdk-pixbuf is a dependency of libheif. When libgdk-pixbuf2.0-dev installed in linux, the installation of libheif:x64-linux fails due to the following error:

CMake Error at gdk-pixbuf/cmake_install.cmake:60 (file):
  file INSTALL cannot copy file
  "/home/xxx/vcpkg/buildtrees/libheif/x64-linux-dbg/gdk-pixbuf/libpixbufloader-heif.so"
  to
  "/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-heif.so":
  Success.

This is because pkg_check_modules finds the system-installed gdk-pixbuf instead of the one installed by vcpkg.

To fix this issue, I added a patch to make pkg_check_modules only look for gdk-pixbuf provided by vcpkg.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Apr 21, 2023
@Cheney-W Cheney-W marked this pull request as ready for review April 23, 2023 02:39
LilyWangLL
LilyWangLL previously approved these changes Apr 24, 2023
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Apr 24, 2023
@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Apr 25, 2023
@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 25, 2023
@BillyONeal BillyONeal merged commit 5824411 into microsoft:master Apr 26, 2023
@BillyONeal
Copy link
Member

Thanks!

@Cheney-W Cheney-W deleted the Dev/Cheney/29156 branch April 26, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libheif] Build error (AOM_USAGE_GOOD_QUALITY undeclared / libpixbufloader-heif.so installation)
4 participants