Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline][qtspeech] Fix target scope promotion #31048

Merged
merged 1 commit into from
Apr 24, 2023
Merged

[vcpkg baseline][qtspeech] Fix target scope promotion #31048

merged 1 commit into from
Apr 24, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Apr 22, 2023 •
edited by Cheney-W
Loading

E.g. for
#31031 https://dev.azure.com/vcpkg/public/_build/results?buildId=88538&view=results
#31034 https://dev.azure.com/vcpkg/public/_build/results?buildId=88531&view=results

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

dg0yt
dg0yt commented Apr 22, 2023
View reviewed changes
ports/qtspeech/portfile.cmake
@@ -22,6 +22,7 @@ qt_install_submodule(PATCHES ${${PORT}_PATCHES}
TOOL_NAMES ${TOOL_NAMES}
CONFIGURE_OPTIONS
${FEATURE_OPTIONS}
-DCMAKE_FIND_PACKAGE_TARGETS_GLOBAL=ON
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should promote this option to qt_install_submodule instead of adding to each port?
Ports might still override it via CONFIGURE_OPTIONS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, but this fixes a baseline problem so I'm going to merge it as is. Thanks!

@Cheney-W Cheney-W self-assigned this Apr 23, 2023
@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Apr 23, 2023
@LilyWangLL LilyWangLL mentioned this pull request Apr 24, 2023
Merged
7 tasks
@BillyONeal BillyONeal merged commit c7a7802 into microsoft:master Apr 24, 2023
@dg0yt dg0yt deleted the qtspeech branch April 25, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@Cheney-W Cheney-W Cheney-W approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg0yt @BillyONeal @Cheney-W