Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libgpiod] update version to 2.0.1 #31074

Merged
merged 8 commits into from
Apr 26, 2023

Conversation

jbbjarnason
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

FYI, there are breaking API changes between those two versions, I am not sure it needs to be handled any differently.

@Adela0814 Adela0814 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 24, 2023
@jbbjarnason
Copy link
Contributor Author

Looking at the logs from the Azure Pipeline it seems that git fetch is failing see here below:

$ cat git-fetch-x64-linux-err.log
error: Server does not allow request for unadvertised object ae275c375477f207912113e5cf190fada78f3f90

If I use checkout on local machine this works flawlessly:

git checkout ae275c375477f207912113e5cf190fada78f3f90
Note: switching to 'ae275c375477f207912113e5cf190fada78f3f90'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at ae275c3 libgpiod v2.0.1

Looking at the docs of vcpkg_from_git there is something called FETCH_REF, does that need to be defined now? If so what should it be, ref to master?

@BillyONeal
Copy link
Member

Thanks for the update!

@Adela0814 Adela0814 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Apr 25, 2023
@Adela0814
Copy link
Contributor

@jbbjarnason I got stuck in fetching during testing:
image

@jbbjarnason
Copy link
Contributor Author

@jbbjarnason I got stuck in fetching during testing: image

@Adela0814 did you use my latest update? As I hoped that everything is okay after I fixed the pipeline when setting FETCH_REF=v2.0.1

@Adela0814
Copy link
Contributor

@jbbjarnason I got stuck in fetching during testing: image

@Adela0814 did you use my latest update? As I hoped that everything is okay after I fixed the pipeline when setting FETCH_REF=v2.0.1

Yes, I used your latest commit. I have tested on several machines and it is the same issue. Is everything okay in your local?

@jbbjarnason
Copy link
Contributor Author

jbbjarnason commented Apr 25, 2023

@Adela0814 yes it works on my local machine

jonb@jonb-work-desktop ~/P/vcpkg (update-libgpiod)> ./vcpkg install libgpiod
Computing installation plan...
The following packages will be built and installed:
    libgpiod[core]:x64-linux -> 2.0.1
  * vcpkg-cmake[core]:x64-linux -> 2022-12-22
  * vcpkg-cmake-get-vars[core]:x64-linux -> 2023-03-02
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-linux...
Restored 2 package(s) from /home/jonb/.cache/vcpkg/archives in 3.67 ms. Use --debug to see more details.
Installing 1/3 vcpkg-cmake:x64-linux...
Elapsed time to handle vcpkg-cmake:x64-linux: 356 us
Installing 2/3 vcpkg-cmake-get-vars:x64-linux...
Elapsed time to handle vcpkg-cmake-get-vars:x64-linux: 343 us
Installing 3/3 libgpiod:x64-linux...
Building libgpiod[core]:x64-linux...
-- Fetching git://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git v2.0.1...
-- Extracting source /home/jonb/Projects/vcpkg/downloads/libgpiod-ae275c375477f207912113e5cf190fada78f3f90.tar.gz
-- Using source at /home/jonb/Projects/vcpkg/buildtrees/libgpiod/src/ada78f3f90-97729933e2.clean
-- Found external ninja('1.11.1').
-- Getting CMake variables for x64-linux
-- Getting CMake variables for x64-linux-dbg
-- Getting CMake variables for x64-linux-rel
-- Generating configure for x64-linux
-- Finished generating configure for x64-linux
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Installing x64-linux-dbg
-- Building x64-linux-rel
-- Installing x64-linux-rel
-- Fixing pkgconfig file: /home/jonb/Projects/vcpkg/packages/libgpiod_x64-linux/lib/pkgconfig/libgpiod.pc
-- Fixing pkgconfig file: /home/jonb/Projects/vcpkg/packages/libgpiod_x64-linux/debug/lib/pkgconfig/libgpiod.pc
-- Installing: /home/jonb/Projects/vcpkg/packages/libgpiod_x64-linux/share/libgpiod/copyright
-- Performing post-build validation
Stored binaries in 1 destinations.
Elapsed time to handle libgpiod:x64-linux: 11 s
Total install time: 11 s

@Adela0814
Copy link
Contributor

This issue only repro on virtual machines without domains.
It was also reproduced in the previous version. I think this shouldn't block this PR.

@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Apr 26, 2023
@BillyONeal
Copy link
Member

This issue only repro on virtual machines without domains. It was also reproduced in the previous version. I think this shouldn't block this PR.

It looks like something your domain is pushing to you is preventing you from hitting git.kernel.org. Or perhaps you can't hit this without going through a proxy, and the git:// protocol doesn't support proxies.

@BillyONeal BillyONeal merged commit 210e4ad into microsoft:master Apr 26, 2023
@BillyONeal
Copy link
Member

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants