[luasocket] bump to 3.1.0

[TheCycoONE]

• Changes comply with the maintainer guide
• SHA512s are updated for each updated download
• The "supports" clause reflects platforms that may be fixed by this new version
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[TheCycoONE]

Updated with the suggestions from @JonLiu1993
Thanks.

[TheCycoONE]

@JonLiu1993 @Cheney-W is anything else expected of me?

[JavierMatosD]

I see you are storing the results of the rename in temp, but I don't see temp being used for anything. Is this intentional or am I missing something?

[TheCycoONE]

It's intentional to avoid failing when the files don't exist. There use to be conditionals on them and even they didn't cover community triplets.

…

On Tue., May 2, 2023, 2:45 p.m. Javier Matos Denizac, < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In ports/luasocket/portfile.cmake <#31078 (comment)>: > if(VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic") # Handle socket dll name - file(RENAME "${CURRENT_PACKAGES_DIR}/bin/socket/socket.core.dll" "${CURRENT_PACKAGES_DIR}/bin/socket/core.dll") - if(EXISTS "${CURRENT_PACKAGES_DIR}/bin/socket/socket.core.pdb") - file(RENAME "${CURRENT_PACKAGES_DIR}/bin/socket/socket.core.pdb" "${CURRENT_PACKAGES_DIR}/bin/socket/core.pdb") - endif() - file(RENAME "${CURRENT_PACKAGES_DIR}/debug/bin/socket/socket.core.dll" "${CURRENT_PACKAGES_DIR}/debug/bin/socket/core.dll") - if(EXISTS "${CURRENT_PACKAGES_DIR}/debug/bin/socket/socket.core.pdb") - file(RENAME "${CURRENT_PACKAGES_DIR}/debug/bin/socket/socket.core.pdb" "${CURRENT_PACKAGES_DIR}/debug/bin/socket/core.pdb") - endif() + file(RENAME "${CURRENT_PACKAGES_DIR}/bin/socket/socket.core.dll" "${CURRENT_PACKAGES_DIR}/bin/socket/core.dll" RESULT temp) + file(RENAME "${CURRENT_PACKAGES_DIR}/bin/socket/socket.core.pdb" "${CURRENT_PACKAGES_DIR}/bin/socket/core.pdb" RESULT temp) + file(RENAME "${CURRENT_PACKAGES_DIR}/debug/bin/socket/socket.core.dll" "${CURRENT_PACKAGES_DIR}/debug/bin/socket/core.dll" RESULT temp) I see you are storing the results of the rename in temp, but I don't see temp being used for anything. Is this intentional or am I missing something? — Reply to this email directly, view it on GitHub <#31078 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGJBCOIXLX55BFO6XTI6FTXEFI3RANCNFSM6AAAAAAXI4TYBQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[TheCycoONE]

https://cmake.org/cmake/help/latest/command/file.html#rename On Tue., May 2, 2023, 6:15 p.m. Stephen E. Baker, ***@***.***> wrote:

…

It's intentional to avoid failing when the files don't exist. There use to be conditionals on them and even they didn't cover community triplets. On Tue., May 2, 2023, 2:45 p.m. Javier Matos Denizac, < ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In ports/luasocket/portfile.cmake > <#31078 (comment)>: > > > if(VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic") > # Handle socket dll name > - file(RENAME "${CURRENT_PACKAGES_DIR}/bin/socket/socket.core.dll" "${CURRENT_PACKAGES_DIR}/bin/socket/core.dll") > - if(EXISTS "${CURRENT_PACKAGES_DIR}/bin/socket/socket.core.pdb") > - file(RENAME "${CURRENT_PACKAGES_DIR}/bin/socket/socket.core.pdb" "${CURRENT_PACKAGES_DIR}/bin/socket/core.pdb") > - endif() > - file(RENAME "${CURRENT_PACKAGES_DIR}/debug/bin/socket/socket.core.dll" "${CURRENT_PACKAGES_DIR}/debug/bin/socket/core.dll") > - if(EXISTS "${CURRENT_PACKAGES_DIR}/debug/bin/socket/socket.core.pdb") > - file(RENAME "${CURRENT_PACKAGES_DIR}/debug/bin/socket/socket.core.pdb" "${CURRENT_PACKAGES_DIR}/debug/bin/socket/core.pdb") > - endif() > + file(RENAME "${CURRENT_PACKAGES_DIR}/bin/socket/socket.core.dll" "${CURRENT_PACKAGES_DIR}/bin/socket/core.dll" RESULT temp) > + file(RENAME "${CURRENT_PACKAGES_DIR}/bin/socket/socket.core.pdb" "${CURRENT_PACKAGES_DIR}/bin/socket/core.pdb" RESULT temp) > + file(RENAME "${CURRENT_PACKAGES_DIR}/debug/bin/socket/socket.core.dll" "${CURRENT_PACKAGES_DIR}/debug/bin/socket/core.dll" RESULT temp) > > I see you are storing the results of the rename in temp, but I don't see > temp being used for anything. Is this intentional or am I missing > something? > > — > Reply to this email directly, view it on GitHub > <#31078 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAGJBCOIXLX55BFO6XTI6FTXEFI3RANCNFSM6AAAAAAXI4TYBQ> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

[dg0yt]

It's intentional to avoid failing when the files don't exist. There use to be conditionals on them and even they didn't cover community triplets.

A variable name like unused would have made this clear.
And I think at least for the DLLs it would have been good to have proper conditionals.