Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][xeus] Fix libuuid dependency #31101

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Apr 25, 2023

Fixes error in Android builds, #31098.

(Didn't I recently insist on mirroring libuuid's supports in another PR? This is why...)

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Adela0814 Adela0814 added category:port-bug The issue is with a library, which is something the port should already support category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. labels Apr 25, 2023
@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 25, 2023

This is not category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. : android triplets are tested in CI now, and this baseline regression blocks PRs, e.g. #31084.

@Adela0814
Copy link
Contributor

This is not category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. : android triplets are tested in CI now, and this baseline regression blocks PRs, e.g. #31084.

Yes, android triplets are tested in CI now, but it hasn't been added to the official triplets yet.
@BillyONeal Do we have any plans to add android to the official triplets?

@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Apr 25, 2023
@dan-shaw dan-shaw merged commit 463a9b7 into microsoft:master Apr 26, 2023
@dg0yt dg0yt deleted the xeus branch April 26, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants