Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openssl] correct fipsmodule install #31142

Merged
merged 4 commits into from
Apr 28, 2023
Merged

[openssl] correct fipsmodule install #31142

merged 4 commits into from
Apr 28, 2023

Conversation

lbermes
Copy link
Contributor

@lbermes lbermes commented Apr 27, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@lbermes
Corrected fipsmodule.cnf install
c963dc8 
move it to the same position as openssl.cnf, both are only examples of openssl
@lbermes
Adjusted port version
b32f784
@lbermes
Adjusted SHA for vcpkg x-add-version --all
17c4688
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Apr 27, 2023
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Apr 28, 2023
@BillyONeal BillyONeal merged commit e52999e into microsoft:master Apr 28, 2023
@BillyONeal
Copy link
Member

Thanks!

@lbermes lbermes deleted the openssl-correct-fipsmodule-install branch April 28, 2023 06:24
@flichtenheld flichtenheld mentioned this pull request Apr 28, 2023
Closed
@daschuer daschuer mentioned this pull request Jun 1, 2023
Merged
fwcd pushed a commit to fwcd/vcpkg that referenced this pull request Aug 21, 2023
@lbermes @BillyONeal @fwcd
[openssl] correct fipsmodule install (microsoft#31142)
1910140 
* Corrected fipsmodule.cnf install

move it to the same position as openssl.cnf, both are only examples of openssl

* Adjusted port version

* Adjusted SHA for vcpkg x-add-version --all

---------

Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbermes @BillyONeal @JonLiu1993