Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pthreads] Fixed whitespaces in path issue #31179

Merged

Conversation

bold84
Copy link
Contributor

@bold84 bold84 commented Apr 29, 2023

Fixes #31174

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@bold84
Copy link
Contributor Author

bold84 commented Apr 29, 2023

@BillyONeal There was no option to allow others to push to this branch

Screenshot 2023-04-29 at 09 41 06

@bold84 bold84 marked this pull request as ready for review April 29, 2023 19:46
@BillyONeal
Copy link
Member

Hmm that's bizarre. Maybe the source branch has protections applied to it or something that are incompatible? 🤷

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels May 4, 2023
@JavierMatosD JavierMatosD merged commit 13a0b7b into microsoft:master May 4, 2023
@daschuer daschuer mentioned this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pthreads build failure
4 participants