-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kf5parts] Add new port #31544
[kf5parts] Add new port #31544
Conversation
7127553
to
2bf98d8
Compare
|
0573f2a
to
fc3b70d
Compare
The above suggested changes are only recommendations. If you are willing to adopt them, please click "ready for review" after making the modifications. If you do not wish to make any changes, please click "ready for review" directly. That way, I can be aware that you've responded. |
Co-authored-by: Cheney Wang <38240633+Cheney-W@users.noreply.github.com>
Yes, addressed the review comments and updated the branch |
Usage test passed with x64-windows triplet. |
Repology tells me the common package name for this is |
@dan-shaw , hello, I think we can, but there is a problem that another KDE Frameworks have port names like |
So, Am I create new PR with |
@dan-shaw What is your opinion on changing the ports of all 36 kf5 in vcpkg? |
(to clarify, I'm not against this ports renaming, I think that we may go futher faster if merge my PR and would make a new PR with bulk renaming (or adding "virtual port" like "qt" and "qt5" 😊 )) |
Thank you! |
Fixes: #31538.
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.