Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline][unicorn-lib] Fix, cleanup #31706

Merged
merged 2 commits into from
May 31, 2023
Merged

[vcpkg baseline][unicorn-lib] Fix, cleanup #31706

merged 2 commits into from
May 31, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented May 29, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

dg0yt
dg0yt commented May 30, 2023
View reviewed changes
ports/unicorn-lib/CMakeLists.txt
Comment on lines +19 to +23
else()
find_package(Iconv REQUIRED)
target_link_libraries(unicorn-lib PRIVATE Iconv::Iconv)
target_compile_definitions(unicorn-lib PRIVATE -D_XOPEN_SOURCE=700)
endif()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key contribution.

@dg0yt dg0yt marked this pull request as ready for review May 30, 2023 06:55
@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision depends:different-pr This PR or Issue depends on a PR which has been filed labels May 30, 2023
@LilyWangLL
Copy link
Contributor

Depends on #31658.

@LilyWangLL LilyWangLL removed the depends:different-pr This PR or Issue depends on a PR which has been filed label May 31, 2023
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 31, 2023
@dan-shaw dan-shaw merged commit 7be26f0 into microsoft:master May 31, 2023
@dg0yt dg0yt deleted the unicorn-lib branch May 31, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dg0yt @LilyWangLL @dan-shaw @Cheney-W