-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fmt] update to 11.0.2 #39738
[fmt] update to 11.0.2 #39738
Conversation
got some error with folly, this's my first time to see such error, will see it tomorrow evening
libfolly.pc:
|
This may be caused by multi-threaded compilation. You can add the DISABLE_PARALLEL_CONFIGURE compilation option and then try compiling. |
This option is for not disabling parallel configuration (i.e. CMake). This helps with parallel writes to the source directory ( |
find an issue facebook/folly#2250 |
All features passed with following triplets:
Usage test pass with following triplets:
|
@jimwang118 my folly patch is based on facebook/folly#2255, but seems facebook/folly#2265 is the chosen one, maybe this pr should not merged now? |
Okay, I have removed the reviewed tag. Maybe you can use vcpkg_download_distfile to directly download this PR as a patch. |
I will change the PR status to Draft. If you have finished editing, please click 'ready for review'. |
Ooooo nice number. Thanks for the updates! |
hi, if vcpkg_cmake_configure set |
If you refer to the |
What dg0yt said. In general we prefer to rely on build system bindings for as little as possible as not every downstream build system listens to such bindings. That's why this replacement was in place before. |
Fixes #40000
./vcpkg x-add-version --all
and committing the result.