Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Test migration to Actions demonstration PR #42067

Closed

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Nov 9, 2024

We are looking to move everything to Actions to:

  • Address compliance burden the vcpkg team currently has to keep dev.azure.com/vcpkg alive.
  • Make it so that GitHub contributors don't need to click 5 times to get their build failure logs.
  • Make it easier to generate console output that makes for a better PR experience for contributors in the future.

Known limitations:

  • GitHub Actions has no equivalent to the test run telemetry originally contributed by @dg0yt .
  • GitHub Actions makes temporary edits to test e.g. a subset of triplets more difficult.

@BillyONeal BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Nov 9, 2024
@BillyONeal BillyONeal self-assigned this Nov 9, 2024
@BillyONeal BillyONeal changed the title [Do not merge] Add example commit to show that Actions are working. [Do not merge] Test migration to Actions demonstration PR Nov 9, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Nov 10, 2024

Make it so that GitHub contributors don't need to click 5 times to get their build failure logs.

It would be great not just for vcpkg if it was easy enough to report the AZP asset download link from the pipeline job so that it can be integrated in PR conversation.

Make it easier to generate console output that makes for a better PR experience for contributors in the future.

Personally I don't see an improvement with GHA output. IMO it would be more relevant to make vcpkg tool and the port scripts highlight actual problems, including messaging out of project mode (currently ending in logs).

@dg0yt
Copy link
Contributor

dg0yt commented Nov 10, 2024

GitHub Actions has no equivalent to the test run telemetry originally contributed by @dg0yt .

FTR I actually use this to assess if ports are build at all or in particular configurations. Recent case: gazebo, cf. #30862 (comment).

@BillyONeal
Copy link
Member Author

It would be great not just for vcpkg if it was easy enough to report the AZP asset download link from the pipeline job so that it can be integrated in PR conversation.

There are so many 'if only' jokes I can put here

Personally I don't see an improvement with GHA output.

Noted, thank you!

IMO it would be more relevant to make vcpkg tool and the port scripts highlight actual problems, including messaging out of project mode (currently ending in logs).

The problem is that right now problems don't show up on GitHub which makes arguing to improve it hard...

@BillyONeal
Copy link
Member Author

@Osyotr @m-kuhn @autoantwort Tagging you three since you 👍 'd above. What are your thoughts? dg0yt's feedback is having me question if we should do this.

@m-kuhn
Copy link
Contributor

m-kuhn commented Nov 12, 2024

I widely use gha, I hope this will improve the evolution of this stack in general. You already caught my interest with the pull_request_target to upload binary caches from pr's (still wondering about the security impact). My 👍 was motivated by this alignment with my usual tools and potential synergies. But also by the promise to make logs more accessible (not only but especially on a phone, the current way to access the logs is not ideal).

I assume you get around the usual 6 hours limit by using custom runners.

Sidenote, I also plan creating a standalone gh action or two, e.g. to create a report about port updates in manifests, cmp qgis/QGIS#59288 (comment) )

@dg0yt
Copy link
Contributor

dg0yt commented Nov 12, 2024

FTR I didn't meant to veto. But I'm just surprised that MS is unable or unwilling to do more for AZP.

Improving output is an issue for local usage, too.

@BillyONeal
Copy link
Member Author

FTR I didn't meant to veto. But I'm just surprised that MS is unable or unwilling to do more for AZP.

Didn't interpret it as a veto. It's more "the main reason for this change is to improve UX for contributors, so if important contributors don't see it as helpful, and we are giving up useful functionality to do it, maybe we shouldn't"

Maybe the AZP folks could change things about the situation, but I assume if they cared a lot about this scenario that deep links would already work.

Improving output is an issue for local usage, too.

Agreed!

@Osyotr
Copy link
Contributor

Osyotr commented Nov 12, 2024

What are your thoughts?

Pros:
+ easy to access artifacts
Cons:
- Things you've mentioned in "known limitations" section (although I only use triplet filtering from time to time)
No change:
- Searching in logs is still awkward

@dg0yt
Copy link
Contributor

dg0yt commented Nov 12, 2024

  • Things you've mentioned in "known limitations" section (although I only use triplet filtering from time to time)

The triplet filtering has two faces. One is editing the default (you and me). The other is the AZP interactive UI (AZP project owners). I would assume that "editing the default" should be possible with GHA, too.
(I know the AZP UI because I ported that feature from homegrown superbuild 😄)

@BillyONeal
Copy link
Member Author

The triplet filtering has two faces. One is editing the default (you and me). The other is the AZP interactive UI (AZP project owners). I would assume that "editing the default" should be possible with GHA, too.

Unfortunately not. pull-request-target gets the .github directory from the target, not the source, branch. If we use pull-request, GitHub doesn't let us get to the caches.

@BillyONeal
Copy link
Member Author

@JavierMatosD @ras0219-msft @AugP @vicroms and I discussed this today. Given that people who were not Billy did not find it blindingly more obvious how to find the failure logs, and the performance issues with linking from the checks page, in addition to the limitations above, we have decided to stick with Azure DevOps for now.

@BillyONeal BillyONeal closed this Nov 13, 2024
@m-kuhn
Copy link
Contributor

m-kuhn commented Nov 13, 2024

GitHub doesn't let us get to the caches.

Write caches -- reading still works

@talregev
Copy link
Contributor

@BillyONeal I like the idea that it will be going to github action. most of the open source project do use github action as their main ci with vcpkg, and it will be more close to them and find bugs quickly.

Will you make more effort on this direction? Thank you in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants