-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Test migration to Actions demonstration PR #42067
[Do not merge] Test migration to Actions demonstration PR #42067
Conversation
746d235
to
ac670d7
Compare
dadf8c6
to
88e8f19
Compare
It would be great not just for vcpkg if it was easy enough to report the AZP asset download link from the pipeline job so that it can be integrated in PR conversation.
Personally I don't see an improvement with GHA output. IMO it would be more relevant to make vcpkg tool and the port scripts highlight actual problems, including messaging out of project mode (currently ending in logs). |
FTR I actually use this to assess if ports are build at all or in particular configurations. Recent case: gazebo, cf. #30862 (comment). |
There are so many 'if only' jokes I can put here
Noted, thank you!
The problem is that right now problems don't show up on GitHub which makes arguing to improve it hard... |
@Osyotr @m-kuhn @autoantwort Tagging you three since you 👍 'd above. What are your thoughts? dg0yt's feedback is having me question if we should do this. |
I widely use gha, I hope this will improve the evolution of this stack in general. You already caught my interest with the I assume you get around the usual 6 hours limit by using custom runners. Sidenote, I also plan creating a standalone gh action or two, e.g. to create a report about port updates in manifests, cmp qgis/QGIS#59288 (comment) ) |
FTR I didn't meant to veto. But I'm just surprised that MS is unable or unwilling to do more for AZP. Improving output is an issue for local usage, too. |
Didn't interpret it as a veto. It's more "the main reason for this change is to improve UX for contributors, so if important contributors don't see it as helpful, and we are giving up useful functionality to do it, maybe we shouldn't" Maybe the AZP folks could change things about the situation, but I assume if they cared a lot about this scenario that deep links would already work.
Agreed! |
Pros: |
The triplet filtering has two faces. One is editing the default (you and me). The other is the AZP interactive UI (AZP project owners). I would assume that "editing the default" should be possible with GHA, too. |
Unfortunately not. |
@JavierMatosD @ras0219-msft @AugP @vicroms and I discussed this today. Given that people who were not Billy did not find it blindingly more obvious how to find the failure logs, and the performance issues with linking from the checks page, in addition to the limitations above, we have decided to stick with Azure DevOps for now. |
Write caches -- reading still works |
@BillyONeal I like the idea that it will be going to github action. most of the open source project do use github action as their main ci with vcpkg, and it will be more close to them and find bugs quickly. Will you make more effort on this direction? Thank you in advance. |
We are looking to move everything to Actions to:
Known limitations: