Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[raylib] Add new port (fix #4500) #5946

Merged
merged 9 commits into from
May 20, 2019
Merged

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Apr 4, 2019

Test project: https://github.com/myd7349/Ongoing-Study/tree/master/cpp/CMake/vcpkg/raylib_examples
Test on:

  • x86-windows
  • x86-windows-static
  • x64-windows
  • x64-windows-static

Currently, this lib fails on x64-linux. And it doesn't support ARM or UWP. Didn't test it with macOS.
I will try to figure out what happens to x64-linux after the holiday.

@myd7349 myd7349 changed the title [raylib] Add new port (fix #4500) [WIP][raylib] Add new port (fix #4500) Apr 4, 2019
@NancyLi1013
Copy link
Contributor

Hi @myd7349, thanks for your contribution to vcpkg. Here are the test results from current CI system, please let me know if you need the related logs or other info.

x64-windows master test notes
raylib Pass New Port
x64-windows-static master test notes
raylib Pass New Port
x64-osx master test notes
raylib Fail New Port
arm64-windows master test notes
raylib Fail New Port
x86-windows master test notes
raylib Pass New Port
x64-linux master test notes
raylib Fail New Port
x64-uwp master test notes
raylib Fail New Port
arm-uwp master test notes
raylib Fail New Port

@grdowns grdowns added the wip label Apr 12, 2019
@grdowns grdowns self-assigned this Apr 29, 2019
@grdowns
Copy link
Contributor

grdowns commented Apr 29, 2019

Hey @myd7349, I tried out x64-linux myself and found that the system packages libxinerama-dev, libxrandr-dev, libx11-dev, libxcursor-dev, and libgl1-mesa-dev are required. I'll update this PR with a systems dependencies message and ensure that these are all found on the build machines so we can get the CI to pass. Thanks for all the work!

@myd7349
Copy link
Contributor Author

myd7349 commented Apr 29, 2019

Hey @myd7349, I tried out x64-linux myself and found that the system packages libxinerama-dev, libxrandr-dev, libx11-dev, libxcursor-dev, and libgl1-mesa-dev are required. I'll update this PR with a systems dependencies message and ensure that these are all found on the build machines so we can get the CI to pass. Thanks for all the work!

Awesome! Thanks for that. I can remove the WIP tag now.

@myd7349 myd7349 changed the title [WIP][raylib] Add new port (fix #4500) [raylib] Add new port (fix #4500) Apr 29, 2019
@grdowns
Copy link
Contributor

grdowns commented Apr 29, 2019

Oops, may have messed up the commit history a bit 😆. I'll fix it momentarily

Edit: Fixed!

ports/raylib/portfile.cmake Outdated Show resolved Hide resolved
@grdowns
Copy link
Contributor

grdowns commented May 20, 2019

Hey @myd7349, I modified the condition for the system dependencies message as it is possible for non-UNIX to target UNIX, and the UNIX variable is populated based on the host machine, not the target. Thanks again for the port!!

@grdowns grdowns merged commit af248a0 into microsoft:master May 20, 2019
@myd7349 myd7349 deleted the raylib-init branch May 20, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants