This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Fix commandPath issues
#1443
Open
Fix commandPath issues
#1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
benmcmorran
suggested changes
Feb 17, 2022
There was a problem hiding this comment.
@austinoneil Can you describe in a bit more detail what issue this PR is solving? It should already be possible to leave arduino.commandPath unset. It will be initialized to some platform-specific reasonable default value.
| Logger.notifyUserError("InvalidCommandPath", new Error(constants.messages.INVALID_COMMAND_PATH + commandPath)); | ||
| } else { | ||
| if(commandPath) { | ||
| execFileSync(commandPath); |
There was a problem hiding this comment.
Why are we executing commandPath here? registerArduinoCommand() is called in many places, some of which don't directly interact with the Arduino IDE.
|
hello, I created a community fork at https://github.com/vscode-arduino/vscode-arduino. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commandPathpopulatedcommandPath