Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Adopt the new VSCode Debug API. #432

Merged
merged 2 commits into from
Oct 25, 2017
Merged

Adopt the new VSCode Debug API. #432

merged 2 commits into from
Oct 25, 2017

Conversation

yaohaizh
Copy link
Contributor

type: "arduino",
request: "launch",
program: "${file}",
cwd: "${workspaceRoot}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cwd: folder?

}

private async resolveDebugConfigurationAsync(config: vscode.DebugConfiguration) {
if (!ArduinoContext.initialized) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in resolve method, why not generate the default settings for if (!config.request)?

@yaohaizh yaohaizh merged commit c02b07b into master Oct 25, 2017
@yaohaizh yaohaizh deleted the yaohai_dev branch November 13, 2017 05:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants