Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Adds way to skip header file provider #565

Merged
merged 2 commits into from
May 28, 2018

Conversation

ThadHouse
Copy link
Contributor

With the VsCode C++ extension 0.17, it now automatically handles #include providers when properly set up.

This shouldn't be completely removed from this extension as there are still some use cases, but this adds a way to disable the arduino extensions provider if the user wants to.

@msftclas
Copy link

msftclas commented May 21, 2018

CLA assistant check
All CLA requirements met.

@ThadHouse ThadHouse force-pushed the optiondisableheadersearch branch from 9d25ed9 to 284c3b1 Compare May 21, 2018 20:19
@Sneezry Sneezry requested review from yaohaizh and removed request for yaohaizh May 28, 2018 05:17
@Sneezry
Copy link
Member

Sneezry commented May 28, 2018

Cool! Could you also update README to add this option to the doc: https://github.com/Microsoft/vscode-arduino#options

With the VsCode C++ extension 0.17, it now automatically handles #include providers when properly set up.

This shouldn't be completely removed from this extension as there are still some use cases, but this adds a way to disable the arduino extensions provider if the user wants to.
@ThadHouse ThadHouse force-pushed the optiondisableheadersearch branch from 284c3b1 to a7622d3 Compare May 28, 2018 05:45
@ThadHouse
Copy link
Contributor Author

I updated the README, and rebased on the newest master.

@Sneezry Sneezry merged commit 67f2d85 into microsoft:master May 28, 2018
@Sneezry
Copy link
Member

Sneezry commented May 28, 2018

Great! Thanks!

@ThadHouse ThadHouse deleted the optiondisableheadersearch branch May 28, 2018 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants