When sub or group is refreshed, refresh the children as well #339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #349
When "refresh" is triggered on the root or a parent, it will only call its refresh, and then call
loadMoreChildren
on itself. However, becauseloadMoreChildrenImpl
doesn't actually create new tree items (since we are caching all of theAppResourceTreeItems
), refreshing the root, the subscription, and the groups didn't actually do anything.By adding
refreshImpl
toSubscriptionTreeItem
andGroupTreeItemBase
, theAppResourceTreeItems
will actually get refreshed now and it'll be a meaningful refresh.I can't fix the root level refresh without affecting performance because if I call refresh in
SubscriptionTreeItem.loadMoreChildrenImpl
, it will activate all of the extensions at once.The root level refresh only works for subscription filtering so I would almost opt to get rid of the refresh button on the ribbon and add it to the groups themselves. It would looks like this: