Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default web app to deploy compatibility #586

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

alexweininger
Copy link
Member

During v1, the tree item ids were not in the ARM id format. So to support the default resource to deploy feature, which uses find tree item, we must convert the ids.

@alexweininger alexweininger requested a review from a team as a code owner February 21, 2023 21:29
nturinski
nturinski previously approved these changes Feb 21, 2023
Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤮

@alexweininger
Copy link
Member Author

🤮

Don't worry, I added tests 😄

@alexweininger alexweininger merged commit 8fce689 into main Feb 21, 2023
@alexweininger alexweininger deleted the alex/scarlet-clownfish branch February 21, 2023 23:27
@microsoft microsoft locked and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants