Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C syntax highlighting issue #3006

Closed
ru-ace opened this issue Jan 6, 2019 · 5 comments
Closed

C syntax highlighting issue #3006

ru-ace opened this issue Jan 6, 2019 · 5 comments

Comments

@ru-ace
Copy link

ru-ace commented Jan 6, 2019

Issue Type: Bug

Pure C code.
cfg is struct.
second cfg.t_low_fan not highlighted properly

cfg.t_low_fan ? (cfg.t_low_fan == 1 ? "low" : "high") : "off";

Screenshot:
image

Extension version: 0.20.1
VS Code version: Code 1.30.1 (dea8705087adb1b5e5ae1d9123278e178656186a, 2018-12-18T18:07:32.870Z)
OS version: Linux x64 4.9.128-0409128-generic

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2699)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: unavailable_software
video_encode: unavailable_software
webgl: enabled
webgl2: enabled
Load (avg) 1, 1, 1
Memory (System) 15.54GB (10.28GB free)
Process Argv --unity-launch
Screen Reader no
VM 0%
@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jan 7, 2019

Our extension doesn't actually implement any C/C++ colorization; instead, VS Code itself relies on the colorization of atom/language-c: I filed a bug at atom/language-c#316 .

@sean-mcmanus
Copy link
Contributor

It looks like VS Code needs to upgrade to using tree sitter: microsoft/vscode#50140 .

@denis-reichelt
Copy link

I have another similar problem with the syntax highlighting:
image
It is not detected, that after the escaped " quotation there is no end of quotation.

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jan 8, 2019

@denis-reichelt I'm not able to reproduce your syntax issue. Can you provide more info on what could be different about what you're using? What color theme are you using? What OS? It would be better to file a new bug.

image

@jeff-hykin
Copy link

I moved this issue to jeff-hykin/cpp-textmate-grammar
@ru-ace we'll keep you updated on the bug here
@sean-mcmanus You can probably close this issue on vscode-cpptools

@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants