Notice: terminal.integrated.shell.* can be null in the upcoming v1.35

[Tyriar]

See microsoft/vscode-python#5743 and microsoft/vscode#74233, you may also be affected by this. If you detect the shell based on the terminal.integrated.shell.* setting you can no longer do this unless the user has specified a shell.

[sean-mcmanus]

I don't see that setting in our code.

@WardenGnaw @pieandcakes Are you guys checking this setting somewhere else or can I close this issue?

[pieandcakes]

We don't use it specifically as we tell VS Code to run stuff in the terminal through the DA's RunInTerminal command. @Tyriar are you suggesting that we need to check that value now or do i need to ask VS Code for clarification?

[Tyriar]

Only if you were reading that setting and using the value, assuming it would always be string do you need to do anything (as it is now a string | null).

[pieandcakes]

@Tyriar Thanks for clarifying it. We currently don't do anything with that value so I'll close this. Thank you for the heads up regarding the change.