Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal not getting activated in Insiders #5743

Closed
DonJayamanne opened this issue May 23, 2019 · 6 comments
Closed

Terminal not getting activated in Insiders #5743

DonJayamanne opened this issue May 23, 2019 · 6 comments
Assignees
@DonJayamanne
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
2019 - May Sprint 11

Comments

@DonJayamanne
Copy link

DonJayamanne commented May 23, 2019 •
edited
Loading

Activation of environments is broken in VSC Insiders.
The configuration setting terminal.integrated.shell.<platform> returns null in insiders.

See below:

  • Operating System: Mac
  • Works in Stable
  • Does not work in Insiders

Version 1.34.0 (1.34.0)
Screen Shot 2019-05-23 at 14 28 47

Version 1.35.0-insider (1.35.0-insider) 2019-05-23T05:07:54.582Z
Screen Shot 2019-05-23 at 14 29 16
@DonJayamanne DonJayamanne self-assigned this May 23, 2019
@DonJayamanne DonJayamanne added this to the 2019 - May Sprint 10 milestone May 23, 2019
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label May 23, 2019
@DonJayamanne
Copy link
Author

DonJayamanne commented May 23, 2019 •
edited
Loading

Upstream issue microsoft/vscode#74233

@DonJayamanne DonJayamanne changed the title Terminal not getting activated Terminal not getting activated in Insiders May 23, 2019
@DonJayamanne DonJayamanne mentioned this issue May 23, 2019
Closed
@DonJayamanne
Copy link
Author

The UI tests (in progress #4692) + Running them against Insiders (#1619) would have picked this up.

Screen Shot 2019-05-23 at 17 15 58

@Tyriar
Copy link
Member

Tyriar commented May 31, 2019 •
edited
Loading

I closed the vscode issue, please try fix this on your end before we go out with 1.35 stable (sometime next week). The proposal is to leverage Terminal.name when you're sending something to a terminal you don't own (see microsoft/vscode#74233 (comment)) and otherwise when the shell is null fill it in with your own default (like this).

The reason the fix has to be on the side of extensions is because otherwise extensions will break when connected to remotes.

@Tyriar Tyriar mentioned this issue May 31, 2019
Closed
@DonJayamanne DonJayamanne mentioned this issue Jun 3, 2019
Merged
6 tasks
@ghost ghost removed the needs upstream fix label Jun 4, 2019
@Meru
Copy link

Meru commented Jun 5, 2019

after this change "run python file in terminal" doesn't work for me under latest release vscode x64/win7x64/ verified on clean profile with just one python extension. print('hello world") returns nothing.

@syagev syagev mentioned this issue Jun 6, 2019
Closed
@Tyriar Tyriar mentioned this issue Jun 7, 2019
Closed
@formulahendry
Copy link
Member

It may be due to microsoft/vscode#75071

@Tyriar
Copy link
Member

Tyriar commented Jun 8, 2019

Proper fix proposal -> microsoft/vscode#75091, it will still need extensions to adopt it though.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
2019 - May Sprint 11
Development

No branches or pull requests
5 participants
@formulahendry @ericsnowcurrently @DonJayamanne @Tyriar @Meru