Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve focus when showing output channel #146

Merged
merged 1 commit into from
Oct 14, 2016

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Sep 26, 2016

I would like to propose that we do not pass focus to the output channel when we open it automatically.

@dbaeumer fyi

@msftclas
Copy link

Hi @bpasero, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Benjamin Pasero). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

1 similar comment
@msftclas
Copy link

Hi @bpasero, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Benjamin Pasero). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@dbaeumer
Copy link
Member

Thanks @bpasero. To my defense I have to say that it is strange that a panel that doesn't allow typing takes focus by default in the first place. Wouldn't it make more sense to never take focus on show and have a separate method focus.

@dbaeumer dbaeumer merged commit 89ed341 into microsoft:master Oct 14, 2016
@bpasero
Copy link
Member Author

bpasero commented Oct 14, 2016

@dbaeumer totally, now you have to convince @jrieken to behave like that and we are all set

@bpasero bpasero deleted the output-nofocus branch October 14, 2016 13:31
@jrieken
Copy link
Member

jrieken commented Oct 17, 2016

Well, the API just surfaces what the output service does by default. I am afraid it's too late to change the defaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants