Setting for comment style when disabling a line #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MariaSolOs should we first get #1506 in and then use the new method |
Absolutely, we should merge the bug-fix first and I'll rebase this PR since otherwise we'll have a merge conflict for sure. |
MariaSolOs
force-pushed
the
disable-rule-comment-style
branch
from
60a66bb
to
79822a1
Compare
|
Alright, this PR was rebased and now the changes from that bug fix have been included as well! :D |
|
Any updates about this? :) |
dbaeumer
requested changes
Aug 29, 2022
dbaeumer
approved these changes
Aug 30, 2022
aeschli
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the feature requested in #1490.