Introduce option to prevent underlining multiple lines

[aleclarson]

I rebased #463 in hopes that you'll reconsider merging this useful feature.

Your main concern seems to be consistency, but that's not a concern shared by ESLint maintainers:

In #8004, it was decided that ESLint should report large ranges if a node with a large range is reported by a rule, and allow integrations to display a smaller report if desired. The reasoning is that different integrations will have different needs with regard to report ranges (for example, an integration that posts comments on GitHub might want to know the entire reported range, whereas an editor integration might only want to highlight a subset of a reported range).
Source

vscode-eslint-singleLineUnderline.mov

[dbaeumer]

I think the video is a good example why underlining the first line is not a good idea. The error is about the fact that role="button" implies some other property. Only underlining <div might not be very helpful.

[aleclarson]

@dbaeumer That's a tradeoff that the user should be able to make on their own

[dbaeumer]

Why do we need this. Wouldn't it be good enough to pass the document to Diagnostics.create

[dbaeumer]

Shouldn't this be end: { line: startLine, character: uinteger.MAX_VALUE }

[dbaeumer]

This should be uinteger.MAX_VALUE do to the restrictions we have in LSP.

[aleclarson]

Oops, didn't know that was a thing :)

[dbaeumer]

See comment about uinteger.MAX_VALUE

[dbaeumer]

The changes look good to me.

@aleclarson you need to accept the CLA (see #1528 (comment)). I will not be able to merge this without you accepting it.

[aleclarson]

@microsoft-github-policy-service agree