Allow eslint.rules.customizations to target all fixable rules #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
Dimava
commented
Dec 4, 2023
| - Prefix the name with a `"!"` to target all rules that _don't_ match the name: `{ "rule": "!no-*", "severity": "info" }` | ||
| - Prefix the name with a `"!"` to target all rules that _don't_ match the name: `{ "rule": "!no-*", "severity": "error" }` | ||
| - Suffix the name with `"@hasFix"` to target the errors which that have autofix available `{ "rule": "no-*@hasFix", "severity": "info" }` | ||
| - Suffix the name with `"!@hasFix"` to target the errors which that _don't_ have autofix available `{ "rule": "no-*@!hasFix", "severity": "error" }` |
| - Prefix the name with a `"!"` to target all rules that _don't_ match the name: `{ "rule": "!no-*", "severity": "info" }` | ||
| - Prefix the name with a `"!"` to target all rules that _don't_ match the name: `{ "rule": "!no-*", "severity": "error" }` | ||
| - Suffix the name with `"@hasFix"` to target the errors which that have autofix available `{ "rule": "no-*@hasFix", "severity": "info" }` | ||
| - Suffix the name with `"!@hasFix"` to target the errors which that _don't_ have autofix available `{ "rule": "no-*@!hasFix", "severity": "error" }` |
There was a problem hiding this comment.
Instead of a suffix on the existing rule property, how about a new property like "fixable"? The suffix is confusing me and won't scale well if more features like it are asked for, such as filtering on whether it provides suggestions or what it's meta.type is.
Proposal:
"eslint.rules.customizations": [
{ "rule": "*", "severity": "warn", "fixable": true },
](caveat: I'm not a VS Code or vscode-eslint maintainer, just the external contributor from #1164 & stumbled onto this)
There was a problem hiding this comment.
@JoshuaKGoldberg I actually like this a lot. I am not really happy with the !@hasFix suffix either.
1 task
sapegin
added a commit
to sapegin/vscode-eslint
that referenced
this pull request
Apr 29, 2024
With the config like this:
```
"eslint.rules.customizations": [
{ "rule": "*", "fixable": true, "severity": "info" }
]
```
It'll downgrade all autofixable problems to the info severity.
Fixes microsoft#1634
Rel microsoft#267, microsoft#680, microsoft#655, microsoft#1705
|
Implemented in #1841 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1634
Related: #267 , #680