Add eslint.codeActionsOnSave.options

[JavaScriptBach]

Add an eslint.codeActionsOnSave.options that allows users to customize the options that ESLint runs with on save. This allows passing in a different set of options to ESLint on save, allowing a greater degree of customization than eslint.codeActionsOnSave.rules.

See motivation in #1938 (comment).

[JavaScriptBach]

@microsoft-github-policy-service agree [company="Vanta"]

[JavaScriptBach]

@microsoft-github-policy-service agree company="Vanta"

[JavaScriptBach]

@dbaeumer I think I've followed your instructions correctly in #1938 (comment). Is there a way I can build and install this extension locally so I can test whether the setting works?

[dbaeumer]

You can run from source

• debug viewlet
• Run Client lauch config

To build and install locally do the following:

• dump the version number 3.0.15
• npm run compile
• install vsce globally
• run vsce package This produces a local vsix file
• Run command: Install from VSIX
• Select the local vsix file

Let me know how it goes.

[dbaeumer]

I did a first quick look and one thing I noticed is: do we want to support to only provide options without any rule modifications. That would have an impact on the code here: https://github.com/microsoft/vscode-eslint/blob/main/server/src/eslint.ts#L515

[JavaScriptBach]

I was thinking if eslint.codeActionsOnSave.options is set, then eslint.codeActionsOnSave.rules should be ignored. The user can supply their own config in options, which means they should still be able to customize the rules.

[dbaeumer]

I was thinking if eslint.codeActionsOnSave.options is set, then eslint.codeActionsOnSave.rules should be ignored. The user can supply their own config in options, which means they should still be able to customize the rules.

I think we should still allow this. If users already customized this and he simply wants to add some basic options I would still prefer to allow this.