Use asWebviewUri instead of vscode-resource directly

microsoft · Sep 13, 2019 · 708bc30 · 708bc30
1 parent 104c10a
commit 708bc30
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 15 deletions.
diff --git a/webview-sample/package-lock.json b/webview-sample/package-lock.json
diff --git a/webview-sample/package.json b/webview-sample/package.json
@@ -4,7 +4,7 @@
 	"version": "0.0.1",
 	"publisher": "vscode-samples",
 	"engines": {
-		"vscode": "^1.32.0"
+		"vscode": "^1.38.0"
 	},
 	"categories": [
 		"Other"
@@ -44,6 +44,6 @@
 		"@types/node": "^10.5.2",
 		"tslint": "^5.16.0",
 		"typescript": "^3.5.1",
-		"@types/vscode": "^1.32.0"
+		"@types/vscode": "^1.38.0"
 	}
 }
diff --git a/webview-sample/src/extension.ts b/webview-sample/src/extension.ts
@@ -137,37 +137,38 @@ class CatCodingPanel {
 	}
 
 	private _update() {
-		const z = 1 + 2;
+		const webview = this._panel.webview;
+
 		// Vary the webview's content based on where it is located in the editor.
 		switch (this._panel.viewColumn) {
 			case vscode.ViewColumn.Two:
-				this._updateForCat('Compiling Cat');
+				this._updateForCat(webview, 'Compiling Cat');
 				return;
 
 			case vscode.ViewColumn.Three:
-				this._updateForCat('Testing Cat');
+				this._updateForCat(webview, 'Testing Cat');
 				return;
 
 			case vscode.ViewColumn.One:
 			default:
-				this._updateForCat('Coding Cat');
+				this._updateForCat(webview, 'Coding Cat');
 				return;
 		}
 	}
 
-	private _updateForCat(catName: keyof typeof cats) {
+	private _updateForCat(webview: vscode.Webview, catName: keyof typeof cats) {
 		this._panel.title = catName;
-		this._panel.webview.html = this._getHtmlForWebview(cats[catName]);
+		this._panel.webview.html = this._getHtmlForWebview(webview, cats[catName]);
 	}
 
-	private _getHtmlForWebview(catGif: string) {
+	private _getHtmlForWebview(webview: vscode.Webview, catGifPath: string) {
 		// Local path to main script run in the webview
 		const scriptPathOnDisk = vscode.Uri.file(
 			path.join(this._extensionPath, 'media', 'main.js')
 		);
 
 		// And the uri we use to load this script in the webview
-		const scriptUri = scriptPathOnDisk.with({ scheme: 'vscode-resource' });
+		const scriptUri = webview.asWebviewUri(scriptPathOnDisk);
 
 		// Use a nonce to whitelist which scripts can be run
 		const nonce = getNonce();
@@ -181,13 +182,13 @@ class CatCodingPanel {
                 Use a content security policy to only allow loading images from https or from our extension directory,
                 and only allow scripts that have a specific nonce.
                 -->
-                <meta http-equiv="Content-Security-Policy" content="default-src 'none'; img-src vscode-resource: https:; script-src 'nonce-${nonce}';">
+                <meta http-equiv="Content-Security-Policy" content="default-src 'none'; img-src ${webview.cspSource} https:; script-src 'nonce-${nonce}';">
 
                 <meta name="viewport" content="width=device-width, initial-scale=1.0">
                 <title>Cat Coding</title>
             </head>
             <body>
-                <img src="${catGif}" width="300" />
+                <img src="${catGifPath}" width="300" />
                 <h1 id="lines-of-code-counter">0</h1>
 
                 <script nonce="${nonce}" src="${scriptUri}"></script>