utf8 encoding on stdout to handle multibyte char Fixes #1469

microsoft · Jan 22, 2018 · 5246a84 · 5246a84
1 parent ceaf023
commit 5246a84
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 1 deletion.
diff --git a/Go-latest.vsix b/Go-latest.vsix
diff --git a/src/goFormat.ts b/src/goFormat.ts
@@ -57,6 +57,7 @@ export class GoDocumentFormattingEditProvider implements vscode.DocumentFormatti
 
 			// Use spawn instead of exec to avoid maxBufferExceeded error
 			const p = cp.spawn(formatCommandBinPath, formatFlags, { env });
+			p.stdout.setEncoding('utf8');
 			p.stdout.on('data', data => stdout += data);
 			p.stderr.on('data', data => stderr += data);
 			p.on('error', err => {

diff --git a/src/goMain.ts b/src/goMain.ts
@@ -56,7 +56,7 @@ export function activate(ctx: vscode.ExtensionContext): void {
 		  "data": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
 	   }
 	 */
-	sendTelemetryEvent('beta-testing', { version: '0.6.74', date: '01/12/2018' });
+	sendTelemetryEvent('beta-testing', { version: '0.6.74', date: '01/21/2018' });
 
 	let useLangServer = vscode.workspace.getConfiguration('go')['useLanguageServer'];
 	let langServerFlags: string[] = vscode.workspace.getConfiguration('go')['languageServerFlags'] || [];