Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Broken selection choice "Open Workspace settings" #1374

Closed
JanKoehnlein opened this issue Nov 27, 2017 · 3 comments
Closed

Broken selection choice "Open Workspace settings" #1374

JanKoehnlein opened this issue Nov 27, 2017 · 3 comments

Comments

@JanKoehnlein
Copy link
Contributor

In goInstallTools.ts the selection result "Open Workspace settings" is not handled properly.
JanKoehnlein added a commit to theia-ide/go-language-server that referenced this issue Nov 27, 2017
@JanKoehnlein
Handle "open workspace settings" properly microsoft#1374
a6e6005
JanKoehnlein added a commit to theia-ide/go-language-server that referenced this issue Nov 27, 2017
@JanKoehnlein
Handle "open workspace settings" properly microsoft#1374
29a6ab0 
Signed-off-by: Jan Koehnlein <jan.koehnlein@typefox.io>
ramya-rao-a pushed a commit that referenced this issue Nov 27, 2017
@JanKoehnlein @ramya-rao-a
Handle "open workspace settings" properly #1374 (#1375)
3c89579 
Signed-off-by: Jan Koehnlein <jan.koehnlein@typefox.io>
@ramya-rao-a
Copy link
Contributor

Fixed with #1375

@ramya-rao-a
Copy link
Contributor

The fix is out in the latest update to the Go extension (0.6.69)

@JanKoehnlein
Copy link
Contributor Author

Cool, thanks.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JanKoehnlein @ramya-rao-a