Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

guru bug: Go/Peak to Implementation works only one way #1536

Closed
kron4eg opened this issue Feb 23, 2018 · 4 comments
Closed

guru bug: Go/Peak to Implementation works only one way #1536

kron4eg opened this issue Feb 23, 2018 · 4 comments

Comments

@kron4eg
Copy link

kron4eg commented Feb 23, 2018

When guru implements used against interface, it reveals all found implementations, when used against concrete type, it reveals interfaces this type implements. But not in vscode-go.

package main

// Some test interface
type Some interface {
	A()
}

type a struct{}

func (*a) A() {}

type b struct{}

func (*b) A() {}

func main() {

}

Steps to Reproduce:

  1. position cursor somewhere in line type Some interface {
  2. call "Peek Implementation" from command line (that works)
  3. position cursor somewhere in line type a struct{}
  4. call "Peek Implementation" from command line (that doesn't work)

#8 related

ramya-rao-a added a commit that referenced this issue Feb 28, 2018
@ramya-rao-a
Copy link
Contributor

I have made the required changes and tested with the above code. Can you help with testing on more real world scenarios? All you need to do is

@kron4eg
Copy link
Author

kron4eg commented Feb 28, 2018

@ramya-rao-a confirm, it works. Thanks a lot for such a quick fix!

@ramya-rao-a
Copy link
Contributor

Thanks for confirming.
Closing this issue now.
Will be releasing an update next week

@ramya-rao-a
Copy link
Contributor

This feature is now available in the latest update (0.6.78) to the Go extension

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants